[HOLD for payment 2023-09-06] [$1000] Workspace - Highlight on text is displayed when email is pressed in Bills screen

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #24244

Action Performed:

1. Open app in iOS
2. Go to Settings > Workspaces > Select a Workspace > Bills
3. Tap on the email shown in the Manage your bills section

Expected Result:

No highlight on text when email is pressed

Actual Result:

Highlight is displayed when email is pressed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.54.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6165815_24244_iOS.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b7076c95fa743b6d
• Upwork Job ID: 1692325576877830144
• Last Price Increase: 2023-08-18
• Automatic offers:
• mollfpr | Reviewer | 26302490

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Highlight on text is displayed when email is pressed in Bills screen

What is the root cause of that problem?

The root cause of the issue is that the container for PressableWithDelayToggle is Text by default. In react native, for iOS, by default, Text has a background colour in pressed state. We're not suppressing the default highlight here.

What changes do you think we should make in order to solve the problem?

We need to add the following here:

            {...props.inline && {suppressHighlighting: true}}

We need to add the above for iOS only, although adding it for all platforms wouldn't really cause any error. We're already doing this here. If that is not an option, then, I think a cleaner way to add this on iOS only would be to create a platform specific Text component that has highlighting disabled by default and name it something like TextWithoutHighlight and use that instead.

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

@joekaufmanexpensify I think the test steps should be updated because this is only reproducible once you are logged in with a non-public domain email account ie user.isFromPublicDomain is false.

[joekaufmanexpensify]

I'm unable to reproduce this at all on iOS (in either an expensifail account, or in a public domain account).

[joekaufmanexpensify]

@allroundexperts could you please share what you're seeing in a public domain account?

[allroundexperts]

Here's what it looks like with a public domain account:

https://github.com/Expensify/App/assets/30054992/5cb636e6-a6fb-45cf-aebe-55f89f84737a

[joekaufmanexpensify]

I don't think that is a bug. There is nothing to select there purposefully as public domain emails do not have a bill intake email address to send in bills (as they don't have a private domain).

[allroundexperts]

Sorry, this happens when you're NOT on a public domain email.

[allroundexperts]

Here is how it looks for non-public emails:

[joekaufmanexpensify]

Got it, thanks for clarifying that!

[joekaufmanexpensify]

Yeah, I cannot reproduce this at all on iOS v1.3.54-11. This is what I see:

[allroundexperts]

@joekaufmanexpensify Try holding the press.

[joekaufmanexpensify]

You mean long pressing on the bill intake email address? If so, doing that highlights the email (as long as I am long pressing). But does not result in the check mark appearing. Which feels like expected behavior IMO.

[allroundexperts]

It should not highlight the Pressables on native platforms. Like this is the bug. For reference, go to any chat that contains a link and try long pressing on it. You won't really see the highlight. Same is the case when you long press the green tick on the same screen.

[allroundexperts]

Ref:

Screen.Recording.2023-08-16.at.2.30.01.AM.mov

Screen.Recording.2023-08-16.at.2.32.49.AM.mov

[allroundexperts]

Here's how this looks on web. Notice that there is no highlight.

Screen.Recording.2023-08-18.at.3.00.50.AM.mov

[joekaufmanexpensify]

Cool cool, yeah I just tested this on mobile web on iOS and web, and confirmed the there is no highlight when long tapping/clicking on the email. It just selects the email (and we show that via the copy checkmark), once you let go of the long tap/click.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b7076c95fa743b6d

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Contributor role ($1000)

[allroundexperts]

PR created #25873 @mollfpr!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: suppress highlight on iOS for workspace bills #25873

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment offer (Reviewer)
• @allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR: feat: use pressable with press feedback #19391
• [@mollfpr / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/19391/files#r1316716014
• [@mollfpr / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@mollfpr / @allroundexperts] Determine if we should create a regression test for this bug.
• [@mollfpr / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[joekaufmanexpensify]

@mollfpr / @allroundexperts mind completing the BZ checklist here so we can prep to issue payment next week?

[joekaufmanexpensify]

Bumped

[joekaufmanexpensify]

@allroundexperts was assigned to this issue on 2023-08-24, and the PR was merged on 2023-08-25, so this qualifies for a speed bonus. This means we need to issue the following payments:

• @allroundexperts - $1,500 ($1000 for PR + $500 speed bonus). Paid via NewDot.
• @mollfpr - $1,500 ($1000 for C+ review +$500 speed bonus). Paid via Upwork.
• No reporting bonus here.

[mollfpr]

Sorry for the delay @joekaufmanexpensify

[@mollfpr / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:

#19391

[@mollfpr / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/19391/files#r1316716014

[@mollfpr / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr / @allroundexperts] Determine if we should create a regression test for this bug.
[@mollfpr / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Login with a expensify.cash email or reverse the condition here.
2. Go to Settings -> Work spaces -> Select Any workspace -> Bills.
3. Click on the email in the Manage your bills section
4. Verify that the click does not highlight the email.
5. 👍 or 👎

[joekaufmanexpensify]

This is a pretty minor bug that doesn't impact the user experience, so my 2c is no regression test is needed here.

[joekaufmanexpensify]

BZ checklist all set!

[joekaufmanexpensify]

@mollfpr $1,500 sent and contract ended!

[joekaufmanexpensify]

@allroundexperts could you please request $1,500 in NewDot and confirm here once complete?

[allroundexperts]

Requested!

[joekaufmanexpensify]

Great, thanks! Going to close this out for now. If your request isn't paid within the next 7 days, LMK and I will look into it.

[joekaufmanexpensify]

Note for the individual paying, that the payment summary message is here.

[JmillsExpensify]

$1,500 approved for payment via NewDot based on BZ summary.