[HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login #29965

kbecciv · 2023-10-19T12:05:34Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.87.1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan /Applause- Internal team reported later
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697694190199399

Action Performed:

Logout if you logged in
Create new account
Enter email which is not used before and enter magic code

Expected Result:

App should not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-10-19.at.11.15.49.AM.mov

MacOS: Desktop

Screen.Recording.2023-10-19.at.11.18.06.AM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0110ec104becd93e90
Upwork Job ID: 1715007628320174080
Last Price Increase: 2023-10-19
Automatic offers:

hoangzinh | Reviewer | 27283181
gadhiyamanan | Reporter | 27283182
situchan | Contributor | 27283230

dukenv0307 · 2023-10-19T12:05:34Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crash on login

What is the root cause of that problem?

After login with a new account ReportActionsView is rendered with reportActions as an empty object briefly

And then the app crashes with this condition because reportActions is {}

App/src/libs/ReportActionsUtils.ts

Line 175 in 229cb5d

    
           const iouRequestActions = reportActions?.filter((action) => action.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && iouRequestTypes.includes(action.originalMessage.type)) ?? [];

What changes do you think we should make in order to solve the problem?

We should safely using _.filter instead of using reportActions?.filter

const iouRequestActions = _.filter(reportActions, (action) => action.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && iouRequestTypes.includes(action.originalMessage.type))

App/src/libs/ReportActionsUtils.ts

Line 175 in 229cb5d

    
           const iouRequestActions = reportActions?.filter((action) => action.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && iouRequestTypes.includes(action.originalMessage.type)) ?? [];

What alternative solutions did you explore? (Optional)

OSBotify · 2023-10-19T12:07:12Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-10-19T12:07:16Z

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

situchan · 2023-10-19T12:22:16Z

@dukenv0307 It's intentional to get rid of _ in TS.

After login with a new account ReportActionsView is rendered with reportActions as an empty object briefly

We should fix this root cause. So there should be no case of reportActions being set to non-array.

melvin-bot · 2023-10-19T14:10:59Z

Job added to Upwork: https://www.upwork.com/jobs/~0110ec104becd93e90

melvin-bot · 2023-10-19T14:11:05Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

melvin-bot · 2023-10-19T14:11:09Z

Upwork job price has been updated to $250

chiragkcodes · 2023-10-19T18:27:37Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes on first login of user.

What is the root cause of that problem?

ReportScreen.js is loading props from Onyx (WithOnyx).
reportActions data is loaded after OpenReport action is called.
During first user login, no reportActions are present due to other action calls being executed(e.g. BeginSignIn, SignInUser,OpenApp), which delays the call to OpenReport action (sequencial)
During this time, Onyx is loading reportActions as an object (Not sure if this is right behavior for Onyx)

When getMostRecentIOURequestActionID gets called during first render of ReportScreen, reportActions is still an object here.

const iouRequestActions = reportActions?.filter(.....

Since, filter() is not defined on object, the app is crashing.

What changes do you think we should make in order to solve the problem?

We need to override reportActions in ReportScreen.js
First we will rename the property reference of reportActions to _reportActions.
This way we wont have to touch existing references of reportActions.

function ReportScreen({
    betas,
    route,
    report,
    reportMetadata,
    reportActions: _reportActions,
   ...

Then within component we will define new local variable which will take care of overriding wrong value (i.e. object to array)

const reportActions = _.isArray(_reportActions)? _reportActions : [];

I tested after these changes, app is not crashing anymore.

What alternative solutions did you explore? (Optional)

Need to investigate why Onyx is loading reportActions as object in the first place.
I believe this will need some deep-dive on react-native-onyx package.

kubabutkiewicz · 2023-10-19T18:45:59Z

@mountiny PR with the fix

melvin-bot · 2023-10-19T22:04:36Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

mountiny · 2023-10-19T22:04:58Z

@situchan $250 for review and testing
@gadhiyamanan $50 for reporting

melvin-bot · 2023-10-20T20:59:59Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-20T21:00:03Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix for App login crash #30014

If no regressions arise, payment will be issued on 2023-10-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@kubabutkiewicz does not require payment (Contractor)
@situchan requires payment offer (Contributor)
@gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-20T21:00:05Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

mallenexpensify · 2023-10-20T21:50:15Z

I'm still getting a crash on login on staging and the PR for/from here already hit staging.

Log in
App crashes

or... try to navigate from a report link to staging.new.expensify.com and it crashes

or... more reliable repro steps
from my mallen@expensifail.com account, try to open mallen@expensify.com to chat with.

Happening on Mac - Chrome and Windows - Chrome (via browserstack)

2023-10-20_14-47-08.mp4

2023-10-20_14-46-26.mp4

situchan · 2023-10-20T21:52:05Z

@mallenexpensify it would be helpful if you can share console log on web

melvin-bot · 2023-10-23T04:40:56Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix for App login crash #30014

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@kubabutkiewicz does not require payment (Contractor)
@situchan requires payment offer (Contributor)
@gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-23T04:40:57Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-30T12:54:30Z

@kubabutkiewicz, @stephanieelliott, @mountiny, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

mountiny · 2023-10-30T13:32:25Z

@mallenexpensify could you please share console logs with that crash?

situchan · 2023-10-30T14:09:31Z

@mallenexpensify could you please share console logs with that crash?

It's different crash - #30109

stephanieelliott · 2023-10-31T22:02:38Z

Is there a regression? Or are we all good to pay here? cc: @mallenexpensify

mountiny · 2023-11-01T11:13:52Z

@stephanieelliott I think we are good to pay @situchan suggested its a different issue

stephanieelliott · 2023-11-01T20:39:54Z

Summarizing payment on this issue:

Issue reporter: @gadhiyamanan $50 -Upwork - PAID
Contributor: N/A
Contributor+: @situchan $250 - Upwork - PAID

Upwork job is here, no bonus is included on final payout

kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Oct 19, 2023

melvin-bot bot added the Daily KSv2 label Oct 19, 2023

OSBotify mentioned this issue Oct 19, 2023

Deploy Checklist: New Expensify 2023-10-18 #29926

Closed

64 tasks

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 19, 2023

melvin-bot bot assigned robertjchen Oct 19, 2023

mountiny added the External Added to denote the issue can be worked on by a contributor label Oct 19, 2023

melvin-bot bot changed the title ~~Login - App crash on login~~ [$500] Login - App crash on login Oct 19, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 19, 2023

melvin-bot bot assigned hoangzinh Oct 19, 2023

mountiny changed the title ~~[$500] Login - App crash on login~~ [$250] Login - App crash on login Oct 19, 2023

mountiny mentioned this issue Oct 19, 2023

[No QA] [TS migration] Migrate 'ReportActionsUtils.js' lib to TypeScript #28570

Merged

57 tasks

mountiny assigned mountiny and unassigned robertjchen Oct 19, 2023

kubabutkiewicz mentioned this issue Oct 19, 2023

[CP Staging] Fix for App login crash #30014

Merged

59 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Oct 19, 2023

mountiny assigned kubabutkiewicz Oct 19, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 19, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 19, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Oct 20, 2023

melvin-bot bot changed the title ~~[$250] Login - App crash on login~~ [HOLD for payment 2023-10-27] [$250] Login - App crash on login Oct 20, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 20, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 23, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-10-27] [$250] Login - App crash on login~~ [HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login Oct 23, 2023

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 27, 2023

melvin-bot bot removed the Overdue label Oct 30, 2023

stephanieelliott closed this as completed Nov 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login #29965

[HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login #29965

kbecciv commented Oct 19, 2023 •

edited by melvin-bot bot

Loading

dukenv0307 commented Oct 19, 2023

OSBotify commented Oct 19, 2023

melvin-bot bot commented Oct 19, 2023

situchan commented Oct 19, 2023 •

edited

Loading

melvin-bot bot commented Oct 19, 2023

melvin-bot bot commented Oct 19, 2023

melvin-bot bot commented Oct 19, 2023

chiragkcodes commented Oct 19, 2023

kubabutkiewicz commented Oct 19, 2023

melvin-bot bot commented Oct 19, 2023

mountiny commented Oct 19, 2023

melvin-bot bot commented Oct 20, 2023

melvin-bot bot commented Oct 20, 2023

melvin-bot bot commented Oct 20, 2023

mallenexpensify commented Oct 20, 2023

situchan commented Oct 20, 2023

melvin-bot bot commented Oct 23, 2023

melvin-bot bot commented Oct 23, 2023

melvin-bot bot commented Oct 30, 2023

mountiny commented Oct 30, 2023

situchan commented Oct 30, 2023

stephanieelliott commented Oct 31, 2023

mountiny commented Nov 1, 2023

stephanieelliott commented Nov 1, 2023

[HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login #29965

[HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login #29965

Comments

kbecciv commented Oct 19, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

dukenv0307 commented Oct 19, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

OSBotify commented Oct 19, 2023

melvin-bot bot commented Oct 19, 2023

situchan commented Oct 19, 2023 • edited Loading

melvin-bot bot commented Oct 19, 2023

melvin-bot bot commented Oct 19, 2023

melvin-bot bot commented Oct 19, 2023

chiragkcodes commented Oct 19, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

kubabutkiewicz commented Oct 19, 2023

melvin-bot bot commented Oct 19, 2023

Bug0 Triage Checklist (Main S/O)

mountiny commented Oct 19, 2023

melvin-bot bot commented Oct 20, 2023

melvin-bot bot commented Oct 20, 2023

melvin-bot bot commented Oct 20, 2023

mallenexpensify commented Oct 20, 2023

situchan commented Oct 20, 2023

melvin-bot bot commented Oct 23, 2023

melvin-bot bot commented Oct 23, 2023

melvin-bot bot commented Oct 30, 2023

mountiny commented Oct 30, 2023

situchan commented Oct 30, 2023

stephanieelliott commented Oct 31, 2023

mountiny commented Nov 1, 2023

stephanieelliott commented Nov 1, 2023

kbecciv commented Oct 19, 2023 •

edited by melvin-bot bot

Loading

situchan commented Oct 19, 2023 •

edited

Loading