Deploy Checklist: New Expensify 2023-10-18

[OSBotify]

Release Version: 1.3.87-12
Compare Changes: production...staging

This release contains changes from the following pull requests:

• forward reportID to ReportActionItemMessageEdit #25951
• UI for room invitations/removals #27966
• [No QA] [TS migration] Migrate 'ReportActionsUtils.js' lib to TypeScript #28570
• mWeb: Keep the focus state of the composer when closing three dots menu in report header #28899
• [No QA] [TS Migration] Migrate PaymentMethods.js to TypeScript #29074
• fix money request tabs animation #29231
• Refactor: Migrate EmojiPickerMenu Class component to Functional Component #29241
• fix: 29056 Back from request money details page does not open request money page #29268
• Fix edit chat converts text to link when making no changes #29418
• Images for Approval Workflows Help SIte #29427
• Create Managing-Employees-and-Reports->-Approval-Workflows.md #29429
• Delete docs/articles/expensify-classic/integrations/travel-integratio… #29516
• feat: add enable wallet button #29573
• Close the modal after clicking on three-dot menu item #29653
• Add deep link for send money #29655
• fix: console error on the description push-to-page in the Send money flow #29673
• inserted zero width character for emoji selection prevention #29686
• Rename const from MONEY_REQUEST_TYPE to TYPE #29696
• [HelpDot] Add a new hub, and rename hubs #29705
• fix: made the the status emoji selector toggle popover #29716
• fixes the cursor for emoji dropdown button #29722
• fix: Android - Keyboard stays open when getting back to amount input page. #29723
• fix: 29620 Site in Spanish automatically changes to English on signing out #29736
• Fix can't download scan receipt image #29738
• fix:28078 Search message shows Invalid email when typing email addres… #29741
• fix iOS receipt border radius is not round #29776
• Revert "Fix navigation breaks on opening search page after reloading the attachment" #29784
• fixed money request button text center issue #29759 #29787
• Fix: Login page loads infinitely when logging in from Another login page is open page #29797
• Delete docs/articles/expensify-classic/bank-accounts-and-credit-cards… #29801
• Fix: navigate to enable-payment page after adding Bank account #29847
• Onfido: update the disabled Send button and Sending button style #29874
• Update getOptions to exclude selected options on FAB #29903
• Update @types/semver to fix vulnerabilities #29913
• [CP-stag] Do not check for defaultCredit #29915
• [CP Staging] Fix for App login crash #30014
• Fix issue with option disappearing when selected for new contacts #30017
• [CP Staging] Navigate to concierge report after workspace member leaves workspace room #30026
• [CP Staging] added component #30081
• Fix crash after deleting a workspace #30084
• fix: update first emoji index on mount #30092
• Prevent useEffect from happening incorrectly for deleted IOU reports #30097

Internal QA:

• Add report card lost or damaged #28141 - @JKobrynski

Deploy Blockers:

• [HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$500] New user disappears from search results when selected #29917
• [HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login #29965
• Workspace - Incorrect left padding for the button which has a left icon #29967
• [$500] Start chat-Removed newly selected participants from search results in group chat flow #29971
• Room - Last name of the invited member disappears in Member list after inviting user to room #29976
• [HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] Room - Nothing happens when clicking Leave room #29977
• [$500] Room - User mention in the system message after inviting member to the room cannot be copied #29978
• Room - No audit trail when removing members from a custom room (not #admin/#announce)  #29979
• Sign In - App crashes when sign in new account via magic link #30016
• [HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] IOU - Tapping delete request, user is directed to "hmm...it's not here" page. #30020
• [PENDING BUG REPORT PAYOUT][$500] Dev: Can't request money using Distance #30022
• [HOLD for payment 2023-11-09] [$500] Wallet - Once after login, debit card page exits without open #30024
• Workspace is not selected as participant when a manual request is created #30032
• [$500] Chat - Secondary login chat after redirecting to primary login -redirects user to Concierge chat #30062
• [HOLD for payment 2023-10-27] [$500] Chat - Emoji are cut off at the top if message contains only emoji and is located under avatar #30064
• [$500] Wallet - Unable completed the wallet connection without receiving correct test data. Connecting BA via Wallet not showing transfer balance onle enable wallet displayed #30069
• [HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$500] Workspace - Crash when deleting a workspace #30078
• [HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Chat - First row emojis are skipped #30083

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.87-0 🚀

[francoisl]

@kavimuru - Heads up that the iOS build has been failing twice in a row so far. We're looking into, but the new iOS build 1.3.87-1 is not available yet.
I'll post a message when that's resolved, in the meantime feel free to start testing on other platforms.

[cristipaval]

Checking off #29967, asked for a CP request here

[kavimuru]

Regression is 28% progress
#29903 failing with #29971
#29797 failing with #29995
#29665 failing with #29972 (Reproducible in production, ok to check it off?)

[francoisl]

We discussed #29978 and decided not to block on it, checking it off.

[jasperhuangg]

Checking off #29976

[francoisl]

Working on the remaining blockers, I'll update the list below gradually as we fix them:

• [HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login #29965 fixed and tested, checking off
• Sign In - App crashes when sign in new account via magic link #30016 fixed as well, it ended up being the same root cause as above
• [$500] Start chat-Removed newly selected participants from search results in group chat flow #29971 was closed as dupe of [HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$500] New user disappears from search results when selected #29917
• [HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] Room - Nothing happens when clicking Leave room #29977 fix tested on staging
• Add deep link for send money #29655 checking as it's repro in production too
• Fix issue with option disappearing when selected for new contacts #30017 tested internally, checking off
• [PENDING BUG REPORT PAYOUT][$500] Dev: Can't request money using Distance #30022 deemed not a blocker
• Add report card lost or damaged #28141 tested internally (for the record, you need to navigate to https://staging.new.expensify.com/settings/wallet/card/expensify.com manually)
• [CP-stag] Do not check for defaultCredit #29915 tested internally
• Fix can't download scan receipt image #29738 also happening on production - I'll leave a comment in the PR to double-check on Android
• fix:28078 Search message shows Invalid email when typing email addres… #29741 works for me on desktop 1.3.87-8, checking off
• Update getOptions to exclude selected options on FAB #29903 works for me on 1.3.87-8, checking off

[kavimuru]

Regression is down to 20%
#29903 failing with #29917
#29797 failing with #29995
#29741 failing with #28078 (Reproducible in Desktop)
#29655 failing with #29972 (Reproducible in production, ok to check it off?)
#29738 failing with #27992 failing in android

[mvtglobally]

Regression is down to 13%
#29573 - CP Validations pending
#29738 failing with #27992 failing in android
#29741 failing with #28078 (Reproducible in Desktop)
#29797 failing with #29995. Repro in PROD. checking off
#29903 failing with #29971
#29915 - CP Validations pending
#30017 - CP Validations pending

[francoisl]

• Still one PR we're testing internally (feat: add enable wallet button #29573, cc @kevinksullivan)
• One deploy blocker still open ([HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] IOU - Tapping delete request, user is directed to "hmm...it's not here" page. #30020), discussing internally

[mvtglobally]

Regression is completed

Open Blockers
#30020
#30064
#30078

Unchecked PR
#29573 - failing with #30069

[francoisl]

Thanks Maria, we're working on the remaining items. I'll update below as we make progress and ping you if anything needs retesting.

---

• [HOLD for payment 2023-11-09] [$500] Wallet - Once after login, debit card page exits without open #30024 - deemed not a blocker, checking off
• [HOLD for payment 2023-10-27] [$500] Chat - Emoji are cut off at the top if message contains only emoji and is located under avatar #30064 - fix tested on staging builds
• [HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$500] Workspace - Crash when deleting a workspace #30078 - tested internally
• feat: add enable wallet button #29573 - QA'ed internally - incomplete test flows will be polished later
• [HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] IOU - Tapping delete request, user is directed to "hmm...it's not here" page. #30020 - fix tested internally

[francoisl]

A fix for the last blocker is in review 🥵. We'll test it internally when it's CP'ed (ETA ~1h) then we should be good to go 🤞

[francoisl]