Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room - Last name of the invited member disappears in Member list after inviting user to room #29976

Closed
6 tasks done
lanitochka17 opened this issue Oct 19, 2023 · 18 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.87-1

Reproducible in staging?: Yes

Reproducible in production?: No, new feature

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to a room
  3. Click on the room header > Members > Invite
  4. Invite a member with first name and last name

Expected Result:

The display name of the invited user will be preserved

Actual Result:

The last name is removed after the member is invited to the room. The display name with the first name reappears after the page is refreshed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6242976_1697721574281.20231019_211748.mp4
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015a808be9b2c62e1a
  • Upwork Job ID: 1715081480551264256
  • Last Price Increase: 2023-10-19
Issue OwnerCurrent Issue Owner: @jasperhuangg
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@iwiznia
Copy link
Contributor

iwiznia commented Oct 19, 2023

@iwiznia
Copy link
Contributor

iwiznia commented Oct 19, 2023

Fixed one issue, but not this one. I am not sure it should be a blocker really since this is a new feature.

@iwiznia
Copy link
Contributor

iwiznia commented Oct 19, 2023

I looked at the onyx data that InviteToRoom returns and either there's no name/last name or there is but has both name and last name.

@jasperhuangg
Copy link
Contributor

This issue is coming from Auth and needs to be fixed internally. PR incoming...

@jasperhuangg jasperhuangg added the Internal Requires API changes or must be handled by Expensify staff label Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~015a808be9b2c62e1a

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (Internal)

@jasperhuangg
Copy link
Contributor

This can't be reviewed by C+

@jasperhuangg jasperhuangg self-assigned this Oct 19, 2023
@jasperhuangg
Copy link
Contributor

Will review the deploy blocker label so that we aren't blocking the App deploy on the Auth deploy. This will get fixed in the next Auth deploy.

@jasperhuangg jasperhuangg added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 19, 2023
@jasperhuangg jasperhuangg reopened this Nov 3, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 6, 2023
@jasperhuangg
Copy link
Contributor

PR for this is still under review, it shouldn't have been closed out

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023
@jasperhuangg jasperhuangg added the Reviewing Has a PR in review label Nov 6, 2023
Copy link

melvin-bot bot commented Nov 14, 2023

@iwiznia, @garrettmknight, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Nov 20, 2023

@iwiznia, @garrettmknight, @jasperhuangg Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Nov 22, 2023

@iwiznia, @garrettmknight, @jasperhuangg 10 days overdue. Is anyone even seeing these? Hello?

Copy link

melvin-bot bot commented Nov 24, 2023

@iwiznia, @garrettmknight, @jasperhuangg 12 days overdue. Walking. Toward. The. Light...

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Nov 27, 2023
Copy link

melvin-bot bot commented Nov 27, 2023

This issue has not been updated in over 14 days. @iwiznia, @garrettmknight, @jasperhuangg eroding to Weekly issue.

@iwiznia iwiznia closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants