[$500] Chat - Secondary login chat after redirecting to primary login -redirects user to Concierge chat

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.3.87-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Preconditions:

1. Prepare an account that has a secondary login assigned
2. Log in with another account and start a conversation with the primary login of the account from step 1
3. Send some messages in the conversation

Steps:

1. Log in with the account that has the conversation with the user that has 2 logins
2. Click on FAB
3. Click on New Chat
4. Search for the Secondary login of the account

Expected Result:

User should be redirected to the conversation with the primary login email

Actual Result:

After redirecting to the conversation with the primary login email - User is redirected to Concierge chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6243880_1697781442347.az_recorder_20231019_222536.mp4

Android: mWeb Chrome

Screen.Recording.20231020.122725.Chrome.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a0a518407b385be4
• Upwork Job ID: 1715300080774799360
• Last Price Increase: 2023-11-24
• Automatic offers:
• dukenv0307 | Contributor | 27865503

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a0a518407b385be4

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[izarutskaya]

Not reproducible in production

Screen.Recording.20231020.122613.Chrome.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Upwork job price has been updated to $250

[mountiny]

This needs to be fixed, but its also an edge case flow we should not hold deploy for imho

[allroundexperts]

@mountiny Since this is not a deploy blocker, why is the price reduced? Aren't all bugs starting at $500?

[mountiny]

I have decreased the price to $250 because I believe this is a minor edge case flow issue hence it is not as important as some other issues. If @JmillsExpensify @MariaHCD disagree, or there will be no proposals after a while, price can be adjusted at any time

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After redirecting to the conversation with the primary login email - User is redirected to Concierge chat

What is the root cause of that problem?

In this line, we're checking if (!report.statusNum && !prevReport.parentReportID) to decide if we want to navigate to Concierge. This is added from this PR to handle the case of the user being removed from a Room. However this is affecting other chat types, for example in this case, the redirection to the primary email chat was already done in here, it should not navigate to Concierge in this case.

What changes do you think we should make in order to solve the problem?

We should isolate the added logic here so it only applies to the policyRoom chatType, which is its intended purpose (or removed from a room). We can update this line to

(report.statusNum === CONST.REPORT.STATUS.CLOSED || (!report.statusNum && !prevReport.parentReportID && prevReport.chatType === CONST.REPORT.CHAT_TYPE.POLICY_ROOM)))

(Only added the && prevReport.chatType === CONST.REPORT.CHAT_TYPE.POLICY_ROOM)

I've tested the removing user from room case and it's still behaving correctly as expected after the change.

What alternative solutions did you explore? (Optional)

NA

[dukenv0307]

@allroundexperts can you give some feedback on my proposal? It was posted a while ago, thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@JmillsExpensify, @MariaHCD, @allroundexperts Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@JmillsExpensify, @MariaHCD, @allroundexperts 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@JmillsExpensify, @MariaHCD, @allroundexperts 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[JmillsExpensify]

@allroundexperts mind providing feedback on the proposal?

[allroundexperts]

Thanks for your proposal @Tony-MK. I think that rendering twice on smaller screens to make sure that reportId is available is sort of flaky. Going through @dukenv0307's proposal again, I think its less flakier as it would just isolate the check to policy rooms only. Let's go with there proposal.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @MariaHCD is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[JmillsExpensify]

PR forcoming

[dukenv0307]

@allroundexperts The PR is ready for review

[JmillsExpensify]

It looks like the automation failed for this issue. Payment summary:

• Issue reporter: QA
• Contributor: $500 @dukenv0307
• Contributor+: $500 @allroundexperts

[JmillsExpensify]

@allroundexperts mind completing the BZ checklist as well?

[allroundexperts]

Checklist

1. UI for room invitations/removals #27966
2. https://github.com/Expensify/App/pull/27966/files#r1431221038
3. I don't think that a Slack conversation is required here since this was a un-intentional miss.
4. A regression test would be helpful. The steps given in the OP look clear enough to me.

[JmillsExpensify]

Contributor paid out, so closing this issue. @allroundexperts please request payment via Expensify when you get a chance!

[JmillsExpensify]

$500 payment to @allroundexperts based on this comment.