Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI for room invitations/removals #27966

Merged
merged 103 commits into from
Oct 19, 2023
Merged

UI for room invitations/removals #27966

merged 103 commits into from
Oct 19, 2023

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Sep 21, 2023 •
edited
Loading

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/316180
PROPOSAL:

Tests/QA

  • You need the following accounts:
    • workspace creator account (workspace admin)
    • workspace member account
    • non workspace member account
  • Create a workspace with the workspace admin
  • Invite the workspace member
  • Created rooms with private/public/restricted visibility on the workspace
  • As the workspace admin, start a DM with the non workspace member.
  1. As the workspace admin, navigate to the room. Click on the report header to open the report details.
  2. Click on the "Members" option. Verify you're taken to the RoomMembersPage.
  3. Click "Invite". Select both the workspace member's and non workspace member. Click "Invite". Verify you're taken back to the RoomMembersPage, and it has been updated to reflect the newly invited participant. Verify there is a room change log in the report that says "invited xxxx".
  4. Select the people you just invited. Click "Remove". Verify a confirmation modal appears.
  5. Click "Remove" on the confirmation modal. Verify that the RoomMembersPage has updated to reflect the removed participants.
  6. Now mention both the workspace member and non workspace member in the room. Verify there is a room change log in the report that says "invited xxxx". Verify the room members are updated to reflect their invitation.
  7. Select the people you just invited. Click "Remove". Verify a confirmation modal appears.
  8. Click "Remove" on the confirmation modal. Verify that the RoomMembersPage has updated to reflect the removed participants.
  9. Repeat 1-5 for all room visibilities.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
web.mov
Mobile Web - Chrome
mweb_chrome.mp4
Mobile Web - Safari
mweb_safari.MP4
Desktop
desktop.mov
iOS
ios.mov
Android
android.mp4

@jasperhuangg jasperhuangg self-assigned this Sep 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot mentioned this pull request Oct 18, 2023
Closed
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

🎯 @s77rt, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #29925.

@Li357
Copy link
Contributor

Li357 commented Oct 18, 2023

@s77rt can you complete checklist fully?

@jasperhuangg
Copy link
Contributor Author

@Li357 finished it off for them

@jasperhuangg jasperhuangg changed the title [HOLD Auth#8937 Web-Expensify#38879] UI for room invitations/removals [HOLD Web-Expensify#38879] UI for room invitations/removals Oct 18, 2023
@jasperhuangg
Copy link
Contributor Author

I'll complete the author checklist once Expensify/Web-Expensify/pull/38879 is deployed, need it to use the adhoc builds.

@OSBotify
Copy link
Contributor

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/27966/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/27966/index.html
Android iOS
desktop 💻 web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/27966/NewExpensify.dmg https://27966.pr-testing.expensify.com
Desktop Web

@jasperhuangg jasperhuangg removed the request for review from marcochavezf October 19, 2023 00:26
@jasperhuangg jasperhuangg changed the title [HOLD Web-Expensify#38879] UI for room invitations/removals UI for room invitations/removals Oct 19, 2023
@jasperhuangg jasperhuangg merged commit 409da51 into main Oct 19, 2023
21 of 24 checks passed
@jasperhuangg jasperhuangg deleted the jasper-uiForRoomInvitations/Removals branch October 19, 2023 00:45
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Oct 19, 2023
@jasperhuangg @OSBotify
Merge pull request #27966 from Expensify/jasper-uiForRoomInvitations/…
3b45bf3 
…Removals

UI for room invitations/removals

(cherry picked from commit 409da51)
@OSBotify OSBotify mentioned this pull request Oct 19, 2023
Closed
64 tasks
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.3.87-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

1 similar comment
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.3.87-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.3.87-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@grgia grgia mentioned this pull request Oct 19, 2023
Closed
6 tasks
@kbecciv kbecciv mentioned this pull request Oct 20, 2023
Closed
6 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.87-12 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

fedirjh
fedirjh reviewed Oct 26, 2023
View reviewed changes
src/libs/PolicyUtils.js
* @param {Object} policies
* @returns {Boolean}
*/
const isPolicyMember = (policyID, policies) => _.some(policies, (policy) => policy.id === policyID);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused a crash #30078 when deleting a workspace, the policy will be null. We should have included safety checks for the policy.

@francoisl francoisl mentioned this pull request Oct 31, 2023
Closed
6 tasks
@sophiepintoraetz
Copy link
Contributor

@fedirjh @jasperhuangg @Li357 can we please get a regression test for the regression it caused here?

@erquhart erquhart mentioned this pull request Nov 1, 2023
Closed
6 tasks
allroundexperts
allroundexperts reviewed Dec 19, 2023
View reviewed changes
src/pages/home/ReportScreen.js
Comment on lines +318 to +319
prevReport.statusNum === CONST.REPORT.STATUS.OPEN &&
(report.statusNum === CONST.REPORT.STATUS.CLOSED || !report.statusNum))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was being applied to all types of reports which caused #30062

@allroundexperts allroundexperts mentioned this pull request Dec 19, 2023
Closed
6 tasks
hungvu193
hungvu193 reviewed Aug 8, 2024
View reviewed changes
src/pages/RoomMembersPage.js
_.each(props.report.participantAccountIDs, (accountID) => {
const details = props.personalDetails[accountID];

if (!details) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to filter out the optimistic personal detail here to prevent this bug.
More detail in this comment

@hungvu193 hungvu193 mentioned this pull request Aug 8, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hungvu193 hungvu193 hungvu193 left review comments

@allroundexperts allroundexperts allroundexperts left review comments

@fedirjh fedirjh fedirjh left review comments

@thesahindia thesahindia thesahindia left review comments

@Li357 Li357 Li357 approved these changes

@s77rt s77rt s77rt approved these changes

Assignees

@jasperhuangg jasperhuangg

Labels
Ready To Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jasperhuangg @s77rt @Li357 @OSBotify @sophiepintoraetz @hungvu193 @allroundexperts @fedirjh @thesahindia