[HOLD for payment 2023-10-27] [$500] Chat - Emoji are cut off at the top if message contains only emoji and is located under avatar

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.87-8

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

1. Open iOS/iPad or Android App
2. Login with any account
3. Go to any chat
4. Send a message that contains only emoji

Expected Result:

Emoji are displayed correctly in chat history

Actual Result:

Emoji are cut off at the top if the message contains only emoji and is located under the avatar and sending time

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native/iPad
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Bug6243906_1697783028433.iOS-Emoji-cut-off.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f9feff479bfdeec1
• Upwork Job ID: 1715303315170639872
• Last Price Increase: 2023-10-20

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f9feff479bfdeec1

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[izarutskaya]

Not reproducible in production

RPReplay_Final1697781760.MP4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emoji are cut off at the top if the message contains only emoji(s)

What is the root cause of that problem?

Issue is happening due to Invisible Characters that was added in this PR, in native devices android and iOS overwrite the ​ Text styling, and in this case it is taking default parent Text styling and overwriting the styles.onlyEmojisText styling thats why it is taking default text fontSize and lineHeight instead of 30

App/src/pages/home/report/ReportActionItemFragment.js

Line 142 in 69cf29e

{checkForEmojiForSelection(text, props.displayAsGroup)}

App/src/pages/home/report/ReportActionItemFragment.js

Lines 103 to 109 in 69cf29e

	const checkForEmojiForSelection = (text, displayAsGroup) => {
	const firstLetterIsEmoji = EmojiUtils.isFirstLetterEmoji(text);
	if (firstLetterIsEmoji && !displayAsGroup && !Browser.isMobile()) {
	return <Text>&#x200b;</Text>;
	}
	return null;
	};

What changes do you think we should make in order to solve the problem?

To the simplest solution I would suggest we should wrap the the <Text>&#x200b;</Text> in the Container View then issue will be solved in native devices and then styling is not being override

like below

<View><Text>&#x200b;</Text></View>

What alternative solutions did you explore? (Optional)

1. we can add the emoji styling to the Invisible Characters text if it only include the emojis like below

<Text  style={[containsOnlyEmojis ? styles.onlyEmojisText : undefined, styles.ltr, ...props.style, isPendingDelete ? styles.offlineFeedback.deleted : undefined]}>&#x200b;</Text>;

2. create a platform dependent Invisible Characters file that only pass to the web and desktop and for native it will pass null as we do not need the Invisible Characters in native devices as original issue is happening in web and desktop

[narefyev91]

@ayazalavi will you be able to fix this asap?

[jayeshmangwani]

If above proposal is valid, then I can work on this, as the issue is already external, and I am available for PR

@narefyev91 @s77rt

[ayazalavi]

@ayazalavi will you be able to fix this asap?

yes sure

[narefyev91]

@jayeshmangwani based on the process - if that was identified as regression from other PR - author of that PR should make changes to resolve the issue

[narefyev91]

Pinging @Li357 as well here

[jayeshmangwani]

based on the process - if that was identified as regression from other PR - author of that PR should make changes to resolve the issue

@narefyev91 Yes, I am aware of that process, but I was asking as this issue has a Help Wanted tag, and I proposed a solution when the issue was open for proposal, but yes, I will keep it in mind for next time to not propose a solution when the issue is regression from some other PR

[narefyev91]

based on the process - if that was identified as regression from other PR - author of that PR should make changes to resolve the issue

@narefyev91 Yes, I am aware of that process, but I was asking as this issue has a Help Wanted tag, and I proposed a solution when the issue was open for proposal, but yes, I will keep it in mind for next time to not propose a solution when the issue is regression from some other PR

@jayeshmangwani I really appreciated your help here - and for sure your solution is correct - i will address that your impact was very important here - and will ask to pay you a bonus after the issue will be resolved

[narefyev91]

@ayazalavi how much time you need to create a PR fix?

[s77rt]

Unassigning since I'm not the C+ here. @sakluger Please assign @narefyev91 and @ayazalavi

[melvin-bot]

📣 @ayazalavi You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[sakluger]

Hey @narefyev91 and @jayeshmangwani, I just discussed this case with the team. It's true that in general, when there is a regression, we want the author of the offending PR to fix it. But when it comes to deploy blockers, because of the urgency, we will accept proposals from other contributors if it allows us to get a fix out quicker.

In this case, because @jayeshmangwani proposed the fix we ended up using, we can pay them the full $500 .

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] added component #30081

If no regressions arise, payment will be issued on 2023-10-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ayazalavi requires payment
• @narefyev91 does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

Thanks for the quick work everyone! I don't think any additional payment is due here since this was a regression from #29686, and the same contributors worked on the fix as the original issue, so payment will be handled in the original issue.

[jayeshmangwani]

In this case, because @jayeshmangwani proposed the fix we ended up using, we can pay them the full $500 .

@sakluger payment is due for me , can you please check here ?

[sakluger]

@jayeshmangwani Sorry for closing before paying out and thanks for letting me know. I've send you an offer via Upwork, please let me know once you've accepted.

[jayeshmangwani]

Thanks for the help @sakluger , I've accepted offer

[sakluger]

Awesome, thanks you - I've completed payment. Sorry again for closing prematurely!