-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Android-Chat-The top of emojis are cut off on applying quote markdown #47899
Comments
Triggered auto assignment to @strepanier03 ( |
@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Edited by proposal-police: This proposal was edited at 2024-08-28 10:22:02 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.The top of emojis are cut off on applying quote markdown. What is the root cause of that problem?The emoji's
Lines 1704 to 1707 in f15a1e4
Line 52 in f15a1e4
While
Lines 235 to 240 in f15a1e4
What changes do you think we should make in order to solve the problem?This issue already happened with
So in this case:
let htmlContent = htmlWithDeletedTag;
if (containsOnlyEmojis) {
htmlContent = Str.replaceAll(htmlContent, '<emoji>', '<emoji islarge>');
htmlContent = Str.replaceAll(htmlContent, '<blockquote>', '<blockquote islarge>');
}
blockquote: HTMLElementModel.fromCustomModel({
tagName: 'blockquote',
contentModel: HTMLContentModel.block,
getMixedUAStyles: (tnode) => {
if (tnode.attributes.islarge === undefined) {
return;
}
return styles.onlyEmojisTextLineHeight;
},
})
|
@strepanier03 Huh... This is 4 days overdue. Who can take care of this? |
Job added to Upwork: https://www.upwork.com/jobs/~01550e0f7b3eac50c6 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh ( |
Easy to reproduce with any combo of emoji. |
Thanks for proposal @daledah. Can you elaborate on why the issue is only reproducible on Android? |
@hoangzinh, @strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@hoangzinh I think it's a problem with react-native itself. You can check out the demo here: https://snack.expo.dev/b1h4FVhn3ZkBsS6XVQJg6. |
Thanks for updates @daledah. I'm thinking about the expectation in this case. When users type emojis with blockquote, should we display emojis in a large style or a normal style? |
I think we'd follow the same styles that regular messages have. So whatever we do for normal emoji-only messages, we'd do here for blockquotes as well. |
Thanks @shawnborton |
@daledah's proposal looks good to me Link to proposal #47899 (comment) 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @daledah You have been assigned to this job! |
@hoangzinh @strepanier03 @aldo-expensify @daledah this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@hoangzinh PR is ready. |
PR is deployed to Prod. Awaiting for payment |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.24
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4884616
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The top of emojis must not be cut off on applying quote markdown.
Actual Result:
The top of emojis are cut off on applying quote markdown.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6579849_1724375588392.Screenrecorder-2024-08-23-06-37-31-905_compress_1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @hoangzinhThe text was updated successfully, but these errors were encountered: