-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [Search v2.3] Add Onyx optimistic and failure data #49439
Comments
Job added to Upwork: https://www.upwork.com/jobs/~021836663116286679327 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Add Onyx optimistic and failure data What is the root cause of that problem?
The save search button is not disabled when we offline
App/src/libs/actions/Search.ts Line 61 in f7a4aa1
What changes do you think we should make in order to solve the problem?
We can add
App/src/libs/actions/Search.ts Line 61 in f7a4aa1
Then we can add App/src/pages/Search/SearchTypeMenu.tsx Line 109 in f7a4aa1
What alternative solutions did you explore? (Optional)NA |
Added @allroundexperts experts as the C+ since he's available now to review, to move this forward. |
@nkdengineer's proposal looks good enough to me. I think we want to go with the optimistic data creation in this case. @lakchote can confirm this. 🎀 👀 🎀 C+ reviewed |
Current assignee @lakchote is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
Let's go with optimistic data creation, yes. @nkdengineer's proposal LGTM. |
📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@allroundexperts The PR is here. |
See #48566 (comment)
You should also optimistically display the saved search.
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @hoangzinhThe text was updated successfully, but these errors were encountered: