Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$100] Android -Profile - Error Message Cut Off When Uploading Large Image to Profile #49485

Open
1 of 6 tasks
IuliiaHerets opened this issue Sep 19, 2024 · 13 comments
Open
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Sep 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: No, prod has another wrong behavior
Email or phone of affected tester (no customers): applausetester+tw345636637997@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to Account Settings > Profile.
  2. Upload a large image (>24MB).

Expected Result:

The error message should display fully when attempting to upload a large image to the profile.

Actual Result:

The error message is cut off when a large image is uploaded to the profile.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6609122_1726767885171.Recorder_19092024_171503.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021836847837390067999
  • Upwork Job ID: 1836847837390067999
  • Last Price Increase: 2024-09-19
Issue OwnerCurrent Issue Owner: @fedirjh
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 19, 2024
Copy link

melvin-bot bot commented Sep 19, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Sep 19, 2024

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 19, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 19, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

Prod behavior
Screenshot_20240919-220025

@etCoderDysto
Copy link
Contributor

etCoderDysto commented Sep 19, 2024

Edited by proposal-police: This proposal was edited at 2024-09-19 19:13:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android -Profile - Error Message Cut Off When Uploading Large Image to Profile

What is the root cause of that problem?

We are not adding styles.w100 to the view below, and the container of AvatarWithImagePicker doesn't take full width

<View style={[styles.pt3, styles.pb6, styles.alignSelfStart]}>

What changes do you think we should make in order to solve the problem?

Add styles.w100

What alternative solutions did you explore? (Optional)

Result Screenshot 2024-09-19 at 10 19 06 at night

@allgandalf
Copy link
Contributor

I guess this should be treated as a new bug, we found out about this during testing (slack convo here), we didn't act on this because the alignment of the error on small screen is not great and eventually decided to report it in our bugs channel

c.c. @rushatgabhane @dangrous

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

Removing deploy blocker label since this is on prod

@grgia grgia added External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 19, 2024
Copy link

melvin-bot bot commented Sep 19, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021836847837390067999

@melvin-bot melvin-bot bot changed the title Android -Profile - Error Message Cut Off When Uploading Large Image to Profile [$250] Android -Profile - Error Message Cut Off When Uploading Large Image to Profile Sep 19, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 19, 2024
Copy link

melvin-bot bot commented Sep 19, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@grgia grgia added Daily KSv2 and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Sep 19, 2024
@grgia grgia changed the title [$250] Android -Profile - Error Message Cut Off When Uploading Large Image to Profile [$100] Android -Profile - Error Message Cut Off When Uploading Large Image to Profile Sep 19, 2024
Copy link

melvin-bot bot commented Sep 19, 2024

Upwork job price has been updated to $100

@puneetlath puneetlath removed their assignment Sep 19, 2024
@Krishna2323
Copy link
Contributor

@grgia, we are handling this issue here.

Copy link

melvin-bot bot commented Sep 23, 2024

@sonialiap, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 23, 2024
@fedirjh
Copy link
Contributor

fedirjh commented Sep 23, 2024

@melvin-bot melvin-bot bot removed the Overdue label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

8 participants