Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-09-18 #49427

Closed
43 tasks done
github-actions bot opened this issue Sep 18, 2024 · 21 comments
Closed
43 tasks done

Deploy Checklist: New Expensify 2024-09-18 #49427

github-actions bot opened this issue Sep 18, 2024 · 21 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Release Version: 9.0.38-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 18, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.38-0 🚀

@grgia grgia self-assigned this Sep 19, 2024
@mountiny
Copy link
Contributor

Checking #49339 off, Shawn already qaed it

@mvtglobally
Copy link

Regression is - 70 % completed

PRs:
#45481 - Pending validation on Web and Desktop
#48517 - Pending validation on mWeb, Desktop, Android and iOS
#49023 - Pending validation on Android and iOS
#49030 - Pending validation on Web
#49194 - Pending validation on iOS
#49199 - Pending validation on Desktop, Android and iOS
#49239 - Issue repro on iOS with #49456. checking off
#49315 - Pending validation on Android and iOS
#49387 - Pending validation on Desktop, Android and iOS

Blockers:
#49443
#49447
#49459
#49461

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

Fix for #49461 waiting for review here - #49471

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

Checking off #49461 CPd the fix

@carlosmiceli
Copy link
Contributor

Checking off #49459 - PR fix is merged.

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

demoted #49447

@mvtglobally
Copy link

Regression is - 97 % completed

PRs:
#45481 - is failing with an issue. Logging in a bit
#48517 - Is failing with KI #48246. repro in PROD
#49194 - Pending validation on iOS
#49315 - Pending validation on iOS
#49387 - is failing with #49374. repro in PROD, checking off

Blockers:
#49466

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

demoting #49483

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

demoting #49485, exists on prod

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

I CPd #49482 which fixes #49466 and may fix #49484

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

Posted in #deployers looking for someone to takeover for today since QA is not complete - https://expensify.slack.com/archives/C07J32337/p1726778019965809

@mvtglobally
Copy link

mvtglobally commented Sep 19, 2024

Regression is completed

PRs:
#45481 - is failing with #49483, not a blocker, checking off
#49194 - Pending validation on iOS

Blockers:
#49466
#49484

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

checking off #49466 and #49484 which were fixed by #49482

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

checking off #48517 as linked bug is reproducible in prod

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

@mvtglobally have you validated #49194 on IOS?

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

I tested #49194 on IOS / staging, so checking off QA

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

woot woot, checklist done

@grgia
Copy link
Contributor

grgia commented Sep 19, 2024

:shipit:

@grgia grgia closed this as completed Sep 19, 2024
@mvtglobally
Copy link

PR #49194 is failing for Android because of issue #49459 which has CP. IOS is pass now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants