-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when switching accounts (again) #48962
Conversation
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
7b1dea7
to
abd202d
Compare
abd202d
to
1bf6e4f
Compare
@rushatgabhane ready for review |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-09-15.at.21.36.56.movAndroid: mWeb ChromeiOS: NativeScreen.Recording.2024-09-15.at.21.35.06.moviOS: mWeb SafariScreen.Recording.2024-09-15.at.21.33.30.movMacOS: Chrome / SafariRegression testScreen.Recording.2024-09-15.at.21.1.mp4ConnectScreen.Recording.2024-09-15.at.21.mp4DisconnectScreen.Recording.2024-09-15.at.21.17.25.movMacOS: DesktopScreen.Recording.2024-09-15.at.21.29.18.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @dangrous, can you review this PR? @cristipaval is OOO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me; have we confirmed that it doesn't cause https://expensify.slack.com/archives/C01GTK53T8Q/p1725890512566159 again?
@dangrous yes we did! it is in the review screenshot for web |
Awesome I missed that! Merging. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.38-0 🚀
|
🚀 Deployed to production by https://github.com/grgia in version: 9.0.38-4 🚀
|
Details
Re-adds #48379 after it was reverted by #48798.
Changes from the original PR:
isEmptyObject(reportOnyx)
check was moved from theisLoadingReportOnyx
variable toshouldShowSkeleton
.Fixed Issues
$ #43656
PROPOSAL: #43656 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
43656.android.native.webm
Android: mWeb Chrome
43656.android.mweb.webm
iOS: Native
43656.ios.native.mp4
iOS: mWeb Safari
43656.ios.mweb.mp4
MacOS: Chrome / Safari
43656.macos.chrome.mov
MacOS: Desktop
43656.macos.desktop.mov