Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New contact method #15330

Merged
merged 47 commits into from
Apr 10, 2023
Merged

New contact method #15330

merged 47 commits into from
Apr 10, 2023

Commits on Feb 21, 2023

  1. Add button for new contact in Contact methods page.

    @cristipaval
    cristipaval committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    4298833 View commit details
    Browse the repository at this point in the history

  2. Create NewContactMethodPage

    @cristipaval
    cristipaval committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    d240884 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Add description

    @cristipaval
    cristipaval committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    2d50115 View commit details
    Browse the repository at this point in the history

  2. Add input field for login.

    @cristipaval
    cristipaval committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    7fcecc5 View commit details
    Browse the repository at this point in the history

  3. Add password input when no passwordless beta

    @cristipaval
    cristipaval committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    d46b4af View commit details
    Browse the repository at this point in the history

  4. Add Button in new contact page.

    @cristipaval
    cristipaval committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    9d1f147 View commit details
    Browse the repository at this point in the history

  5. New contact methid button is not a fixed footer.

    @cristipaval
    cristipaval committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    fc38d21 View commit details
    Browse the repository at this point in the history

  6. Submit form when no passwordless beta.

    @cristipaval
    cristipaval committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    d028688 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/main' into cristi_new-contact-me… 

    …thod
    @cristipaval
    cristipaval committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    38a5de7 View commit details
    Browse the repository at this point in the history

  8. Add form validation.

    @cristipaval
    cristipaval committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    9c9c703 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. For no, submit new contact method form only when no passwordless

    @cristipaval
    cristipaval committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    0dcbed8 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Merge remote-tracking branch 'origin/main' into cristi_new-contact-me… 

    …thod
    @cristipaval
    cristipaval committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    2a08b96 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Integrate New Contact Method command

    @cristipaval
    cristipaval committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    782b3b2 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into cristi_new-contact-me… 

    …thod
    @cristipaval
    cristipaval committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    b58614d View commit details
    Browse the repository at this point in the history

  3. Fix conflicts after merge.

    @cristipaval
    cristipaval committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    9723aa7 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Fix validateForm function

    @cristipaval
    cristipaval committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    01ed14a View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Improve the onyx data when calling AddNewContactMethod command

    @cristipaval
    cristipaval committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    64577c1 View commit details
    Browse the repository at this point in the history

  2. Show magic code stuff in ContactMethodDetailsPage only if there are n… 

    …o addedLogin errors.
    @cristipaval
    cristipaval committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    636fc3c View commit details
    Browse the repository at this point in the history

  3. Show errorFields.addedLogin in ContactMethodDetails

    @cristipaval
    cristipaval committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    017af2f View commit details
    Browse the repository at this point in the history

  4. Delete contact method on server only if has been added successfully.

    @cristipaval
    cristipaval committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    b2df6c4 View commit details
    Browse the repository at this point in the history

  5. Show error description when a contact method failed to be added.

    @cristipaval
    cristipaval committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    047ee98 View commit details
    Browse the repository at this point in the history

  6. Small typo in i18n

    @cristipaval
    cristipaval committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    85e59bd View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Merge remote-tracking branch 'origin/main' into cristi_new-contact-me… 

    …thod
    @cristipaval
    cristipaval committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    335e47b View commit details
    Browse the repository at this point in the history

  2. Remove LoginField.

    @cristipaval
    cristipaval committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    28ad9d0 View commit details
    Browse the repository at this point in the history

  3. Remove AddSecondaryLoginPage

    @cristipaval
    cristipaval committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    cbfd568 View commit details
    Browse the repository at this point in the history

  4. Do nothing if the new contact method is already claimed by the user.

    @cristipaval
    cristipaval committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    3a7f5a6 View commit details
    Browse the repository at this point in the history

  5. Disable autoCapitalize the input field on NewContactMethodPage

    @cristipaval
    cristipaval committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    5f53d85 View commit details
    Browse the repository at this point in the history

  6. Remove deprecated set secondary login command

    @cristipaval
    cristipaval committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    3211e81 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Show pending state for the added contact method while offline.

    @cristipaval
    cristipaval committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    836ed2e View commit details
    Browse the repository at this point in the history

  2. Lint

    @cristipaval
    cristipaval committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    9bae9f8 View commit details
    Browse the repository at this point in the history

  3. Lint

    @cristipaval
    cristipaval committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    2959e90 View commit details
    Browse the repository at this point in the history

  4. Lint

    @cristipaval
    cristipaval committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    47a6c4d View commit details
    Browse the repository at this point in the history

  5. Lint

    @cristipaval
    cristipaval committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    512fb39 View commit details
    Browse the repository at this point in the history

  6. Give me the green checkmark Linter, or Imma quit!

    @cristipaval
    cristipaval committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    071b551 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Improve translations.

    @cristipaval
    cristipaval committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    aba9ecf View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary optimistic data.

    @cristipaval
    cristipaval committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    ee5252f View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary default to null.

    @cristipaval
    cristipaval committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    12cfc2c View commit details
    Browse the repository at this point in the history

  4. Update src/pages/settings/Profile/Contacts/ContactMethodsPage.js 

    Co-authored-by: Marc Glasser <marc.aaron.glasser@gmail.com>
    @cristipaval @marcaaron
    cristipaval and marcaaron committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c37480e View commit details
    Browse the repository at this point in the history

  5. Update src/pages/settings/Profile/Contacts/ContactMethodsPage.js 

    Co-authored-by: Marc Glasser <marc.aaron.glasser@gmail.com>
    @cristipaval @marcaaron
    cristipaval and marcaaron committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f9f0fde View commit details
    Browse the repository at this point in the history

  6. Update src/pages/settings/Profile/Contacts/NewContactMethodPage.js 

    Co-authored-by: Marc Glasser <marc.aaron.glasser@gmail.com>
    @cristipaval @marcaaron
    cristipaval and marcaaron committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f7e874c View commit details
    Browse the repository at this point in the history

  7. Update src/ROUTES.js 

    Co-authored-by: Alex Beaman <alexbeaman@expensify.com>
    @cristipaval @Beamanator
    cristipaval and Beamanator committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    db660c7 View commit details
    Browse the repository at this point in the history

  8. Update src/libs/actions/User.js 

    Co-authored-by: Alex Beaman <alexbeaman@expensify.com>
    @cristipaval @Beamanator
    cristipaval and Beamanator committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    b7835f4 View commit details
    Browse the repository at this point in the history

  9. Address feedback.

    @cristipaval
    cristipaval committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e722fb6 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Fix Linter errors.

    @cristipaval
    cristipaval committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    73f6a78 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Improve the look of New Contact Method button

    @cristipaval
    cristipaval committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    6b8383a View commit details
    Browse the repository at this point in the history

  2. Do not ask for confirmation when deleting a contact method which has … 

    …errors.
    @cristipaval
    cristipaval committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    7553807 View commit details
    Browse the repository at this point in the history

  3. Add function doc.

    @cristipaval
    cristipaval committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    539fa78 View commit details
    Browse the repository at this point in the history