Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stuck navigation & Re-add Contact Method Details pages #15751

Merged
merged 36 commits into from
Mar 29, 2023
Merged

Fix stuck navigation & Re-add Contact Method Details pages #15751

merged 36 commits into from
Mar 29, 2023

Commits on Mar 8, 2023

  1. No need to call Navigate.navigate

    @aldo-expensify
    aldo-expensify committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    4237497 View commit details
    Browse the repository at this point in the history

  2. Redirect on componentDidUpdate instead of render

    @aldo-expensify
    aldo-expensify committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    99a10ac View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Add everything back that got reverted

    @Beamanator
    Beamanator committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    a2056b5 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Fix lint and missing LoginField

    @Beamanator
    Beamanator committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    05274b2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:Expensify/App into aldo_fix-delete-… 

    …phone-number
    @Beamanator
    Beamanator committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    46b9f43 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'beaman-recreateShowAllExpensifyLogins' into aldo_fix-de… 

    …lete-phone-number
    @Beamanator
    Beamanator committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    887a57c View commit details
    Browse the repository at this point in the history

  4. A bit of cleanup

    @Beamanator
    Beamanator committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    17fd385 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Merge branch 'main' of github.com:Expensify/App into aldo_fix-delete-… 

    …phone-number
    @aldo-expensify
    aldo-expensify committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2200f69 View commit details
    Browse the repository at this point in the history

  2. Merge with main / resolve conflicts

    @aldo-expensify
    aldo-expensify committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    4952847 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Remove Navigation.isNavigating

    @aldo-expensify
    aldo-expensify committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    b659e1b View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Resolve conflicts / merge main

    @aldo-expensify
    aldo-expensify committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    463f198 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Polish

    @aldo-expensify
    aldo-expensify committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    109479b View commit details
    Browse the repository at this point in the history

  2. Show NOT FOUND when contact method is missing

    @aldo-expensify
    aldo-expensify committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    e0354df View commit details
    Browse the repository at this point in the history

  3. Update comments

    @aldo-expensify
    aldo-expensify committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    6420459 View commit details
    Browse the repository at this point in the history

  4. Update comment about follow up PR

    @aldo-expensify
    aldo-expensify committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    6e0de62 View commit details
    Browse the repository at this point in the history

  5. Remove unused prop size

    @aldo-expensify
    aldo-expensify committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    c2931da View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' of github.com:Expensify/App into aldo_fix-delete-… 

    …phone-number
    @aldo-expensify
    aldo-expensify committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    5b4ed14 View commit details
    Browse the repository at this point in the history

  7. Update comment 

    Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
    @aldo-expensify @parasharrajat
    aldo-expensify and parasharrajat committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1d7502b View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Fix margins

    @aldo-expensify
    aldo-expensify committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    5eb315a View commit details
    Browse the repository at this point in the history

  2. Use CONST

    @aldo-expensify
    aldo-expensify committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    2d7094c View commit details
    Browse the repository at this point in the history

  3. Submit validation code on press enter

    @aldo-expensify
    aldo-expensify committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    1aed80b View commit details
    Browse the repository at this point in the history

  4. Restrict autocomplete to phones only

    @aldo-expensify
    aldo-expensify committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    4f52414 View commit details
    Browse the repository at this point in the history

  5. Remove unused css

    @aldo-expensify
    aldo-expensify committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    21f6623 View commit details
    Browse the repository at this point in the history

  6. Merge main / Resolve conflicts

    @aldo-expensify
    aldo-expensify committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    7f66b8f View commit details
    Browse the repository at this point in the history

  7. Remove required from prop types / add defaults

    @aldo-expensify
    aldo-expensify committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    634ed14 View commit details
    Browse the repository at this point in the history

  8. Pass correct autoComplete value depending on type

    @aldo-expensify
    aldo-expensify committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    012faeb View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Add new validation to magic code input

    @Beamanator
    Beamanator committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    fc31a8d View commit details
    Browse the repository at this point in the history

  2. Reuse existing validate code validation

    @Beamanator
    Beamanator committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    322e72a View commit details
    Browse the repository at this point in the history

  3. Clear error on successful submit

    @Beamanator
    Beamanator committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    afe51f4 View commit details
    Browse the repository at this point in the history

  4. Only handle touch in resend validate code text

    @aldo-expensify
    aldo-expensify committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    5749c3b View commit details
    Browse the repository at this point in the history

  5. 4px to the left

    @aldo-expensify
    aldo-expensify committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    eb71724 View commit details
    Browse the repository at this point in the history

  6. Fix lint issues

    @Beamanator
    Beamanator committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    f95dbda View commit details
    Browse the repository at this point in the history

  7. Make resend checkmark 4 px from text

    @Beamanator
    Beamanator committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    6cc7921 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of github.com:Expensify/App into aldo_fix-delete-… 

    …phone-number
    @Beamanator
    Beamanator committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    7b9c665 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Fix bug requiring double tap to submit

    @aldo-expensify
    aldo-expensify committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    6151893 View commit details
    Browse the repository at this point in the history

  2. All keypad input to blur on submit

    @Beamanator
    Beamanator committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    82dd1a4 View commit details
    Browse the repository at this point in the history