-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all uses of actorEmail
as part of personalDetails migration (try 2)
#22327
Conversation
@joelbettner Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@0xmiroslav are you able to help test this PR since it's basically the same as #21874, with a few minor fixes? |
yes |
Reviewer Checklist
Screenshots/VideosWebtest1.movtest2.movtest3.movMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.38-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀
|
cc @MonilBhavsar @puneetlath since y'all reviewed the last version of this (here: #21874) which got reverted (here: #22303)
Details
As part of the personalDetails migration, I removed any uses of
reportAction_*.actorEmail
.actorAccountID
Also Note: It looks like the regression bug (#22286) was actually fixed in this PR: #22269 so there was probably no need to revert this 😬 But too late!!
Fixed Issues
$ Related to #19007
Tests
The changes in this PR are mainly to tests or generic changes. Other changes were mainly related to threads & tasks so I'll focus on testing those for this PR.
Moderation tests:
Request money tests:
Offline tests
To verify that the regression doesn't still exist here:
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android