fix non-toggle popover to toggle #24645

ishpaul777 · 2023-08-16T20:14:48Z

Details

Fixed Issues

$ #24284
PROPOSAL: #24284 (comment)

Tests

Verify that no errors appear in the JS console
Navigate to Payment, then verify clicking "Add Payment Method" toggle the PopoverMenu.
Create and assign a Task to any user, open task report, then verify clicking on "Threedots" in top right toggles popover menu.
navigation to any workspace, , then verify clicking on "Threedots" in top right toggles popover menu.
Open any workspace chat, then request money, open IOU report, verify clicking dropdown button in top right toggle the PopoverMenu.

Offline tests

QA Steps

Verify that no errors appear in the JS console
Navigate to Payment, then verify clicking "Add Payment Method" toggle the PopoverMenu.
Create and assign a Task to any user, open task report, then verify clicking on "Threedots" in top right toggles popover menu.
navigation to any workspace, , then verify clicking on "Threedots" in top right toggles popover menu.
Open any workspace chat, then request money, open IOU report, verify clicking dropdown button in top right toggle the PopoverMenu.

PR Author Checklist

Screenshots/Videos

Web

chrome.mov

Mobile Web - Chrome

Uploading safari-1.mov…

mwebchrome-1.mov

Mobile Web - Safari

Desktop

desktop.mov

iOS

ios.mp4

Android

android-1.mov

melvin-bot · 2023-08-16T20:14:53Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2023-08-16T20:15:53Z

I have read the CLA Document and I hereby sign the CLA

ishpaul777 · 2023-08-17T17:55:28Z

@aimane-chnaif Completed the PR author checklist can you review?

aimane-chnaif · 2023-08-18T08:56:16Z

@ishpaul777 please fix conflict

src/components/KYCWall/BaseKYCWall.js

aimane-chnaif · 2023-08-18T10:46:56Z

@ishpaul777 apply code changes from main...aimane-chnaif:Expensify:fix/24284-popover-toggle.
Let me know if you can do in an hour. Otherwise I will work on this myself

ishpaul777 · 2023-08-18T11:52:28Z

I'll apply changes in few minutes sorry for delay @aimane-chnaif

aimane-chnaif · 2023-08-18T11:54:30Z

I'll apply changes in few minutes sorry for delay @aimane-chnaif

ok, and test again on all platforms, cases

ishpaul777 · 2023-08-18T12:42:19Z

@aimane-chnaif i think the positioning of popover menu in KYCWall is not right, Can you confirm if this expected/known

desktop.mp4

aimane-chnaif · 2023-08-18T12:43:26Z

@aimane-chnaif i think the positioning of popover menu in KYCWall is not right, Can you confirm if this expected/known

please check if also happens on main. If so, out of scope

ishpaul777 · 2023-08-18T12:46:08Z

producable on production. Should I report this as bug?

Screen.Recording.2023-08-18.at.6.14.39.PM.mov

aimane-chnaif · 2023-08-18T12:49:46Z

WIth that bug, I couldn't test properly. So I changed position manually here to verify that my fix works

App/src/components/KYCWall/BaseKYCWall.js

Line 138 in 6319e59

vertical: this.state.anchorPositionVertical,

reproducible on production. Should I report this as bug?

I can report this

ishpaul777 · 2023-08-18T13:05:26Z

okay cool!

ishpaul777 · 2023-08-18T13:34:01Z

it works @aimane-chnaif. I just messed up while trying to clean up the code.

src/components/ButtonWithDropdownMenu.js

ishpaul777 · 2023-08-18T13:38:33Z

@aimane-chnaif Review changes when you got the chance, would be great if we can merge before lapse of today.

ishpaul777 · 2023-08-18T14:45:38Z

can you complete Reviewer checklist @aimane-chnaif if there are no other concerns?

aimane-chnaif · 2023-08-18T14:46:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Screen.Recording.2023-08-18.at.3.45.16.PM.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif

LGTM 🎉
@PauloGasparSv all yours

PauloGasparSv

LGTM and tests well!

OSBotify · 2023-08-18T18:13:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-21T22:24:13Z

🚀 Deployed to staging by https://github.com/PauloGasparSv in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:07:14Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix non-toggle popover to toggle

7b34685

ishpaul777 requested a review from a team as a code owner August 16, 2023 20:14

melvin-bot bot requested review from aimane-chnaif and removed request for a team August 16, 2023 20:14

This comment was marked as outdated.

Sign in to view

ishpaul777 and others added 3 commits August 17, 2023 20:47

fix toggle for addpayment method in BaseKycwall

1f0d557

Merge branch 'main' into fix/nontoggle-popover-to-toggle

c37572f

code formatting

6a48e49

aimane-chnaif reviewed Aug 18, 2023

View reviewed changes

src/components/KYCWall/BaseKYCWall.js Outdated Show resolved Hide resolved

ishpaul777 added 2 commits August 18, 2023 17:34

Merge branch 'main' into fix/nontoggle-popover-to-toggle

37a4d17

Merge branch 'main' into fix/nontoggle-popover-to-toggle

452199a

ishpaul777 added 2 commits August 18, 2023 18:37

resolve merge conflicts and requested changes

a1e10e1

code formatting

498f3ee

ishpaul777 requested a review from aimane-chnaif August 18, 2023 13:09

remove time oute

e499934

This comment was marked as resolved.

Sign in to view

resolve error with passing argument to children

a59b419

aimane-chnaif reviewed Aug 18, 2023

View reviewed changes

src/components/ButtonWithDropdownMenu.js Show resolved Hide resolved

ishpaul777 requested a review from aimane-chnaif August 18, 2023 13:38

add comment in proptypes

79c5816

aimane-chnaif approved these changes Aug 18, 2023

View reviewed changes

melvin-bot bot requested a review from PauloGasparSv August 18, 2023 14:47

PauloGasparSv approved these changes Aug 18, 2023

View reviewed changes

PauloGasparSv merged commit 402c70c into Expensify:main Aug 18, 2023
14 checks passed

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

aimane-chnaif mentioned this pull request Aug 28, 2023

[HOLD for payment 2023-10-16] [$500] Add payment method popover has wrong position #26070

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix non-toggle popover to toggle #24645

fix non-toggle popover to toggle #24645

ishpaul777 commented Aug 16, 2023 •

edited

Loading

melvin-bot bot commented Aug 16, 2023

ishpaul777 commented Aug 16, 2023

This comment was marked as outdated.

This comment was marked as outdated.

ishpaul777 commented Aug 17, 2023

aimane-chnaif commented Aug 18, 2023

aimane-chnaif commented Aug 18, 2023

ishpaul777 commented Aug 18, 2023 •

edited

Loading

aimane-chnaif commented Aug 18, 2023 •

edited

Loading

ishpaul777 commented Aug 18, 2023

aimane-chnaif commented Aug 18, 2023

ishpaul777 commented Aug 18, 2023

aimane-chnaif commented Aug 18, 2023

ishpaul777 commented Aug 18, 2023

This comment was marked as resolved.

ishpaul777 commented Aug 18, 2023

ishpaul777 commented Aug 18, 2023 •

edited

Loading

ishpaul777 commented Aug 18, 2023

aimane-chnaif commented Aug 18, 2023

aimane-chnaif left a comment

PauloGasparSv left a comment

OSBotify commented Aug 18, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

fix non-toggle popover to toggle #24645

fix non-toggle popover to toggle #24645

Conversation

ishpaul777 commented Aug 16, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 16, 2023

ishpaul777 commented Aug 16, 2023

This comment was marked as outdated.

This comment was marked as outdated.

ishpaul777 commented Aug 17, 2023

aimane-chnaif commented Aug 18, 2023

aimane-chnaif commented Aug 18, 2023

ishpaul777 commented Aug 18, 2023 • edited Loading

aimane-chnaif commented Aug 18, 2023 • edited Loading

ishpaul777 commented Aug 18, 2023

aimane-chnaif commented Aug 18, 2023

ishpaul777 commented Aug 18, 2023

aimane-chnaif commented Aug 18, 2023

ishpaul777 commented Aug 18, 2023

This comment was marked as resolved.

ishpaul777 commented Aug 18, 2023

ishpaul777 commented Aug 18, 2023 • edited Loading

ishpaul777 commented Aug 18, 2023

aimane-chnaif commented Aug 18, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

PauloGasparSv left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 18, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

ishpaul777 commented Aug 16, 2023 •

edited

Loading

ishpaul777 commented Aug 18, 2023 •

edited

Loading

aimane-chnaif commented Aug 18, 2023 •

edited

Loading

ishpaul777 commented Aug 18, 2023 •

edited

Loading