Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Apple Sign In token path #25710

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Fix Apple Sign In token path #25710

merged 2 commits into from
Aug 22, 2023

Commits on Aug 22, 2023

  1. Fix Apple Sign In token path

    @lindboe
    lindboe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9bed4b5 View commit details
    Browse the repository at this point in the history

  2. Remove token override 

    The `lodashGet` call was causing an error, saying webpack couldn't load
the module, at least when used with ngrok.

```
Uncaught TypeError: lodash_get__WEBPACK_IMPORTED_MODULE_4___default()(...) is undefined
    lodashGet index.website.js:20
    successListener index.website.js:57
    ge appleid.auth.js:26
    we appleid.auth.js:26
    <anonymous> appleid.auth.js:26
    <anonymous> appleid.auth.js:26
    <anonymous> appleid.auth.js:26
    EventListener.handleEvent* appleid.auth.js:26
```

Remove the call so that it's more easily testable. Developers can
override values just fine, and QA won't need it.
    @lindboe
    lindboe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    89d0945 View commit details
    Browse the repository at this point in the history