fix: 10731 Focus composer without showing keyboard when users go to chats

[christianwen]

Details

Fixed Issues

$ #10731
PROPOSAL: #10731 (comment)

Tests

1. Go to any chats
2. Verify that the composer is focused and the virtual keyboard is not shown. After touching on the composer, the keyboard is shown

• Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

1. Go to any chats
2. Verify that the composer is focused and the virtual keyboard is not shown. After touching on the composer, the keyboard is shown

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

e-android.native.mov

Android: mWeb Chrome

e-android.mweb.mov

iOS: Native

e-ios.mov

iOS: mWeb Safari

e-safari.mov

MacOS: Chrome / Safari

e-web.mov

MacOS: Desktop

e-desktop.mov

[melvin-bot]

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[0xmiros]

1. Go to any chats
2. Verify that the composer is focused and the virtual keyboard is not shown. After touching on the composer, the keyboard is shown

I am not sure if this is the expected behavior. @ntdiary can you confirm this doesn't conflict with your refactor?

[Santhosh-Sellavel]

I am not sure if this is the expected behavior.
@0xmiroslav Can you add more context for this why you think this way?

[ntdiary]

1. Go to any chats
2. Verify that the composer is focused and the virtual keyboard is not shown. After touching on the composer, the keyboard is shown

I am not sure if this is the expected behavior. @ntdiary can you confirm this doesn't conflict with your refactor?

I need some time to understand this issue first. :)

[Santhosh-Sellavel]

@ntdiary @0xmiroslav bump

I am not sure if this is the expected behavior.

@0xmiroslav Can you add more context for this why you think this way?

[ntdiary]

@ntdiary @0xmiroslav bump

I am not sure if this is the expected behavior.

@0xmiroslav Can you add more context for this why you think this way?

@Santhosh-Sellavel, we have a PR #29199 that aims to standardize the behavior of refocusing when a modal is closed (including BaseModal, PopoverWithoutOverlay, and RHP), which will address many refocusing issues. The basic principle is that if there is a focused input box before opening the modal, then the focus will be restored after closing the modal. If there is no focus before opening, then it will not be restored.

So, after it is merged, the main input box will no longer gain focus if we complete the money request from the green plus button, which means that the keyboard will no longer be pulled up (for all mobile native/mWeb platforms).

As for whether the main composer should be focused when we open a chat from LHN, it is beyond the scope of that PR.

demo.mp4

[Santhosh-Sellavel]

@christianwen can you resolve conflicts, please?

[christianwen]

merged main

[Santhosh-Sellavel]

@christianwen Sorry for the delay, can resolve conflicts please?

[christianwen]

@Santhosh-Sellavel I fixed the conflicts, can you help process review this PR to avoid the conflicts? Thanks

[Santhosh-Sellavel]

@christianwen
Bug: On tapping composer to bring Keyboard, Keyboard gets dismissed automatically on mWeb iOS

Screen.Recording.2024-01-26.at.1.04.52.AM.mov

[christianwen]

Checking...

[Santhosh-Sellavel]

Any update?

[Santhosh-Sellavel]

Bump @christianwen

[christianwen]

I faced with some errors when building iOS.Pls give me a day to fix it

[Santhosh-Sellavel]

@christianwen
Bug: On tapping composer to bring Keyboard, Keyboard gets dismissed automatically on mWeb iOS

Screen.Recording.2024-01-26.at.1.04.52.AM.mov

@christianwen this happens on mWeb iOS

[Santhosh-Sellavel]

Any update @christianwen

[christianwen]

I'll raise the fix on rn-live-markdown soon

[DylanDylann]

@christianwen Please ping me when all dones

[christianwen]

@DylanDylann PR fix on RN-livemarkdown: Expensify/react-native-live-markdown#499

[christianwen]

I also cleanup isFocusedWhileChangingInputMode logic, maybe it's fixed somewhere else

[DylanDylann]

@christianwen Please upgrade the RN live markdown version

[DylanDylann]

@christianwen Also please resolve conflict and failure test

[christianwen]

@DylanDylann Updated! For the perf issue, we shouldn't mind about it since this test is to compare the number of re-render when users interact with input in baseline (from main) with the current behavior (this PR). In this PR we try to open the keyboard when they focus on the composer -> it takes 2 times to re-render

[DylanDylann]

@christianwen You mean this perf test is invalid now

[DylanDylann]

How about this comment: https://github.com/Expensify/App/pull/32711/files#r1758443883

[christianwen]

will update soon

[DylanDylann]

@christianwen Bump on #10731 (comment)

[christianwen]

Thank you @DylanDylann. I'm updating the PR

[christianwen]

@DylanDylann updated!

[christianwen]

You mean this perf test is invalid now

Yes

[DylanDylann]

@christianwen If that, should we update the perf test to align with new change

[christianwen]

If that, should we update the perf test to align with new change

I think we can't, since we're comparing the behavior between main and this PR

[DylanDylann]

Ahh see. Thanks

[DylanDylann]

@christianwen Safari Bug: Keyboard doesn't appear

Screen.Recording.2024-09-25.at.15.28.07.mov

[DylanDylann]

BUG: The keyboard doesn't show on Android (only show if clicking two times)

Screen.Recording.2024-09-25.at.17.44.01.mov