Add inline images preview to the Live Markdown Input on the web #49250

Skalakid · 2024-09-16T10:02:18Z

Details

This PR bumps the version of the react-native-live-markdown to the latest and enables the inline image previews inside the input on the web

Fixed Issues

$ #40181 (comment)
$ #48797

PROPOSAL:

Tests

Inline image preview

Open any chat room / page with Live Markdown input
Enter inline image markdown. For example:

*test* ![demo image](https://picsum.photos/id/1067/200/300)_test_

Verify the behavior of the input with image preview inside
Verify the loading indicator styling and layout before the image loads
Verify the size and aspect ratio of the image preview
Verify other cases where image can break the input

#48797

Initiate a DM with any user
Compose a message
Place the cursor in the middle of the composed message
Press the Delete button on the keyboard

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

web only feature

Android: mWeb Chrome

chrome.mov

iOS: Native

web only feature

iOS: mWeb Safari

ios.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-09-16T11:12:04Z

@dubielzyk-expensify @hungvu193 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-09-16T11:28:37Z

Do we need to use [image preview]? Wouldn't just using [image] be easier?

shawnborton · 2024-09-16T11:30:02Z

It seems like the height of the image jumps a bit when we load it... any ideas what's happening there? It goes from this:

To this:

Skalakid · 2024-09-16T11:43:21Z

Do we need to use [image preview]? Wouldn't just using [image] be easier?

I used image preview only as an example; you can type whatever you want there

Skalakid · 2024-09-16T11:47:19Z

It seems like the height of the image jumps a bit when we load it... any ideas what's happening there? It goes from this:

It's because I'm changing the source URL of the image, and the browser is loading it once again since it can be completely different image. While loading we are rendering the loading indicator that has 20px of height. The image loads pretty quick so loading indicator disappears instantly and that why we have a layout jump.

Also, on the screen shots that you posted I'm changing the URL variables (width and height) to get the image with different resolution, it's also the reason of the jump

Skalakid · 2024-09-16T11:48:50Z

@mountiny, can we get an adhoc build for testing so we can all easily verify how inline images behave in action, please?

shawnborton · 2024-09-16T13:11:59Z

Hmm I keep getting a broken image when I try this with the adhoc build, I've tried multiple URLs too:

hungvu193 · 2024-09-16T13:44:18Z

just tried the adhoc build and I got the same issue with @shawnborton

Here's the logs:

hungvu193 · 2024-09-16T14:33:05Z

It's working with Dev, so I assume that we will need to wait for BE to deploy to make it work with Staging, just like videos, we will need to whitelist these URL right? 😄

hungvu193 · 2024-09-16T14:42:24Z

@Skalakid Can we add a debounce or wait until the user ends their inputting before another preview?

Screen.Recording.2024-09-16.at.21.39.29.mov

Skalakid · 2024-09-17T10:37:24Z

@hungvu193 I've added a debounce for inline image previews :D

hungvu193 · 2024-09-17T10:59:39Z

@hungvu193 I've added a debounce for inline image previews :D

Awesome!. It's working! 🎉 .

I've found this bug, if you added multiple inline images at the same time, when you edit that message, the first image won't show up.

Screen.Recording.2024-09-17.at.17.58.04.mov

hungvu193 · 2024-09-20T13:40:07Z

Thanks for your quick work 🚀 let me test it

Skalakid · 2024-09-20T13:47:01Z

Another issue, I think that it will need advice from @Expensify/design team.
If we send an invalid inline image (the URL is broken), an empty placeholder will appear, if we click on it, a loading spinner will show infinitely. I think we should display a placeholder for broken image instead. Any thoughts?

I think that we should fix this issue in a separate PR, since it's more connected to E/App itself and how attachments are being displayed in the chat and the attachment modal

hungvu193 · 2024-09-20T14:57:46Z

@Skalakid It worked 🚀 . I've wondered if we should add a loading spinner when we're back online? What's your thought?

Screen.Recording.2024-09-20.at.21.54.49.mov

Skalakid · 2024-09-20T15:05:42Z

@hungvu193 Hmm, I'm not sure. I think it's a tiny detail for now, and we can add it in other PR that will bump the library

hungvu193 · 2024-09-20T15:06:37Z

@hungvu193 Hmm, I'm not sure. I think it's a tiny detail for now, and we can add it in other PR that will bump the library

Agreed 😄 This LGTM, I'll complete the checklist

hungvu193 · 2024-09-20T15:28:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-09-20.at.22.34.58.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-09-20.at.22.25.19.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Screen.Recording.2024-09-20.at.22.23.07.mov

hungvu193 · 2024-09-20T15:29:17Z

Note

For the QA: We will handle this one (#49250 (comment)) and #49250 (comment) in a separate PR.

rafecolton · 2024-09-20T16:24:26Z

Requesting a review from Jack too since he is working on the markdown preview feature. I will do a review for both that and the forward delete issue.

thienlnam · 2024-09-20T18:04:22Z

Woo! Nice work getting it here - changes look good but since this is a big bump this might be good to have tested by QA as well

thienlnam · 2024-09-20T18:05:06Z

Just generated a new build of the latest, and will have applause run through some tests for the composer

github-actions · 2024-09-20T18:38:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49250/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/49250/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49250/NewExpensify.dmg	https://49250.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

lanitochka17 · 2024-09-23T16:59:34Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Mark down - Image preview in the composer loads infinitely when opened in thread

Version Number: 9.0.39-0
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Go to https://49250.pr-testing.expensify.com/
Go to DM
Type anything in the composer
Click + > Add attachment
Select a photo and send it
Right click on the message > Reply in thread
Right click on the message in thread > Edit message

Expected Result:

The image preview in the composer will not load infiniftely

Actual Result:

The image preview in the composer loads infinitely when opened in thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6612778_1727109930897.20240924_004024.mp4

Upwork Automation - Do Not Edit

lanitochka17 · 2024-09-23T17:22:45Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

mWeb - Task - Description entered is not shown in task preview

Version Number: 9.0.39-0
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Go to https://49250.pr-testing.expensify.com/home
Tap on a chat
Tap plus icon -- assign task
Enter title and description
Tap next

Expected Result:

Description entered must be shown in task preview

Actual Result:

Description entered is not shown in task preview

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6612781_1727110034749.Screenrecorder-2024-09-23-22-12-44-97_compress_1.mp4

Upwork Automation - Do Not Edit

lanitochka17 · 2024-09-23T17:49:01Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

mWeb - Room - The text saved in private notes section is not shown

Version Number: 9.0.39-0
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Go to https://49250.pr-testing.expensify.com/home
Open a group chat
Tap private notes
Enter a text and save it
Tap private notes section again

Expected Result:

The text saved in private notes section must be shown

Actual Result:

The text saved in private notes section is not shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6612840_1727113107966.az_recorder_20240923_223645_compress_1.mp4

Upwork Automation - Do Not Edit

lanitochka17 · 2024-09-23T18:03:30Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

mWeb - Composer - Text cursor appears behind the first letter after tapping keyboard spacebar

Version Number: 9.0.39-0
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Precondition:

Keyboard is Samsung keyboard

Go to https://49250.pr-testing.expensify.com/
Go to DM
Type a word and do not select any word from the suggestion (make sure the typed word still has underline)
Tap keyboard spacebar

Expected Result:

The text cursor will be at the end of the word

Actual Result:

The text cursor appears behind the first letter after tapping keyboard spacebar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6612846_1727113339788.1727111451020_Screen_Recording_20240924_010925_Chrome__1_.mp4

Upwork Automation - Do Not Edit

lanitochka17 · 2024-09-23T20:25:43Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Web - Compose box - Emojis entered from OS-built emojis are rendered as small emojis

Version Number: 9.0.39-0
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Precondition:

Sign in to https://49250.pr-testing.expensify.com/
Navigate to a conversation
While focusing on compose box, enter emojis from OS-build emojis

Expected Result:

Emojis have big size in compose box and the send button works

Actual Result:

Emojis are rendered in small size and send button is disabled

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6613010_1727122626916.bandicam_2024-09-23_20-59-04-879.mp4

Upwork Automation - Do Not Edit

dubielzyk-expensify · 2024-09-23T23:41:46Z

Tested this locally with the branch and it's looking awesome! At least the inline image side of it. I'll leave the rest to testing, but from a visual perspective this is good to go 👍

hungvu193 · 2024-09-24T03:04:52Z

This bug from QA is interesting.
I assume that we won't let user edit their message if they attach image right? AFAIR, if we send a message along with an image, we're only able to edit the text of that message.

hungvu193 · 2024-09-24T03:07:54Z

This bug is being handled here

mvtglobally · 2024-09-24T15:11:22Z

QA regression has been completed

Skalakid · 2024-09-25T14:10:37Z

Hello, thanks for the QA regression tests, I'm back at the office and I'm starting to investigate them

Skalakid · 2024-09-25T15:15:20Z

@lanitochka17 I wasn't able to reproduce the following issues, can you check it again, but with the latest main merged?

mWeb - Task - Description entered is not shown in task preview

new.task.mov

mWeb - Room - The text saved in the private notes section is not shown

private.notes.mov

Skalakid · 2024-09-25T15:37:57Z

@lanitochka17 Oh, okay, everything happens on Samsung devices.. I will continue the investigation tomorrow

Skalakid added 4 commits September 16, 2024 11:39

Bump react-native-live-markdown version to 0.1.151

8f2d39c

Change inline image styles

df02ed9

Change image loading indicator styles

9e348f1

Fix lint error

739716e

Skalakid marked this pull request as ready for review September 16, 2024 11:11

Skalakid requested review from a team as code owners September 16, 2024 11:11

melvin-bot bot requested review from dubielzyk-expensify and hungvu193 and removed request for a team September 16, 2024 11:12

Skalakid mentioned this pull request Sep 16, 2024

[Live Markdown] Show the inline image in the live preview #40181

Open

mountiny added the Ready To Build label Sep 16, 2024

mountiny assigned Skalakid Sep 16, 2024

This comment has been minimized.

Sign in to view

This was referenced Sep 17, 2024

Fix caret position in web when deleting forward with no characters selected Expensify/react-native-live-markdown#496

Merged

Add inline images follow ups Expensify/react-native-live-markdown#497

Merged

Skalakid added 2 commits September 17, 2024 12:25

Merge branch 'main' into @Skalakid/inline-images-feature

5ca74c5

Bump react-native-live-markdown version to 0.1.153

01b478c

hungvu193 approved these changes Sep 20, 2024

View reviewed changes

melvin-bot bot requested a review from rafecolton September 20, 2024 15:28

rafecolton requested a review from thienlnam September 20, 2024 16:24

This was referenced Sep 23, 2024

Enlarge emojis in other contexts than just single character messages #47547

Open

[$1000] Make emojis larger in other contexts than just single character messages #4114

Open

dubielzyk-expensify approved these changes Sep 23, 2024

View reviewed changes

Merge branch 'main' into @Skalakid/inline-images-feature

a4807f2

Add inline images preview to the Live Markdown Input on the web #49250

Are you sure you want to change the base?

Add inline images preview to the Live Markdown Input on the web #49250

Conversation

Skalakid commented Sep 16, 2024 • edited by rafecolton Loading

Details

Fixed Issues

Tests

Inline image preview

#48797

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 16, 2024

shawnborton commented Sep 16, 2024

shawnborton commented Sep 16, 2024

Skalakid commented Sep 16, 2024

Skalakid commented Sep 16, 2024 • edited Loading

Skalakid commented Sep 16, 2024

This comment has been minimized.

shawnborton commented Sep 16, 2024

hungvu193 commented Sep 16, 2024 • edited Loading

hungvu193 commented Sep 16, 2024

hungvu193 commented Sep 16, 2024

Skalakid commented Sep 17, 2024 • edited Loading

hungvu193 commented Sep 17, 2024

hungvu193 commented Sep 20, 2024

Skalakid commented Sep 20, 2024 • edited Loading

hungvu193 commented Sep 20, 2024

Skalakid commented Sep 20, 2024

hungvu193 commented Sep 20, 2024

hungvu193 commented Sep 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hungvu193 commented Sep 20, 2024 • edited Loading

rafecolton commented Sep 20, 2024

thienlnam commented Sep 20, 2024

thienlnam commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

lanitochka17 commented Sep 23, 2024 • edited Loading

Mark down - Image preview in the composer loads infinitely when opened in thread

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

lanitochka17 commented Sep 23, 2024 • edited Loading

mWeb - Task - Description entered is not shown in task preview

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

lanitochka17 commented Sep 23, 2024

mWeb - Room - The text saved in private notes section is not shown

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

lanitochka17 commented Sep 23, 2024

mWeb - Composer - Text cursor appears behind the first letter after tapping keyboard spacebar

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

lanitochka17 commented Sep 23, 2024 • edited Loading

Web - Compose box - Emojis entered from OS-built emojis are rendered as small emojis

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

dubielzyk-expensify commented Sep 23, 2024

hungvu193 commented Sep 24, 2024 • edited Loading

hungvu193 commented Sep 24, 2024

mvtglobally commented Sep 24, 2024

Skalakid commented Sep 25, 2024 • edited Loading

Skalakid commented Sep 16, 2024 •

edited by rafecolton

Loading

Skalakid commented Sep 16, 2024 •

edited

Loading

hungvu193 commented Sep 16, 2024 •

edited

Loading

Skalakid commented Sep 17, 2024 •

edited

Loading

Skalakid commented Sep 20, 2024 •

edited

Loading

hungvu193 commented Sep 20, 2024 •

edited

Loading

hungvu193 commented Sep 20, 2024 •

edited

Loading

lanitochka17 commented Sep 23, 2024 •

edited

Loading

lanitochka17 commented Sep 23, 2024 •

edited

Loading

lanitochka17 commented Sep 23, 2024 •

edited

Loading

hungvu193 commented Sep 24, 2024 •

edited

Loading

Skalakid commented Sep 25, 2024 •

edited

Loading

Skalakid commented Sep 25, 2024 •

edited

Loading