-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix task assignee regex can't accept multi-level domains #49685
base: main
Are you sure you want to change the base?
Fix task assignee regex can't accept multi-level domains #49685
Conversation
Can't send a message on Android mWeb. android.mweb.mp4 |
@@ -129,13 +129,14 @@ function ReportFooter({ | |||
* Group 2: Optional email group between \s+....\s* start rule with @+valid email or short mention | |||
* Group 3: Title is remaining characters | |||
*/ | |||
const taskRegex = /^\[\]\s+(?:@([^\s@]+(?:@\w+\.\w+)?))?\s*([\s\S]*)/; | |||
const emailWithOptionalDomainRegex = /(?=((?=[\w'#%+-]+(?:\.[\w'#%+-]+)*@?)[\w\.'#%+-]{1,64}(?:@(?:(?=[a-z\d]+(?:-+[a-z\d]+)*\.)(?:[a-z\d-]{1,63}\.)+[a-z]{2,63}))?(?= |_|\b))(?<end>.*))\S{3,254}(?=\k<end>$)/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to use the email regex from expensify-common
. The only differences is the optional domain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I just removed the unnecessary character because the linter asked to.
I notice that if we create the task with a short mention, but our email is a public domain, the task will fail, for example:
The current logic assumes that the current user is using a private domain email, but in this example, it's a public domain, so we send the API request without the domain as
|
Details
When we create a task from the composer, it can't accept assignee email with multi-level domains (e.g., example@example.co.id).
Fixed Issues
$ #49454
PROPOSAL: #49454 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
test
, not.id test
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4