Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check every second to redraw pickers #191

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Aug 14, 2024

Fixes https://github.com/Expensify/Expensify/issues/417562

Tests

  • Have a GH issue open
  • Add a comment
  • Verify that the pickers in the sidebar are redrawn

@tgolen tgolen requested a review from rafecolton August 14, 2024 19:38
@tgolen tgolen self-assigned this Aug 14, 2024
rafecolton
rafecolton previously approved these changes Aug 15, 2024
Copy link
Member

@rafecolton rafecolton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well. Approving in case you want to publish as a temporary fix - you will need to bump the version as well.

Were you going to try out a version with the mutation observer? That seems like a more "correct" fix, though this works just fine.

@tgolen
Copy link
Contributor Author

tgolen commented Aug 15, 2024

Yeah, I spent a good two hours trying to get the mutation observer to work. It ended up being pretty difficult. I could never get it to observe the right element to detect when the DOM changed (I know it sounds like that's exactly what the mutation observer is built for, but it's really quite fidgety). In the end, I spent enough time on it and decided to go with this more simple approach.

@tgolen tgolen marked this pull request as ready for review August 15, 2024 20:00
@tgolen
Copy link
Contributor Author

tgolen commented Aug 15, 2024

All right, it's been working OK so I did the version bump and I can deploy this tomorrow

@tgolen tgolen merged commit 09bea8d into main Aug 16, 2024
3 checks passed
@tgolen tgolen deleted the tgolen-fix-sidebarrendering branch August 16, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants