Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated Buffer constructor usage #7

Closed
wants to merge 1 commit into from
Closed

replace deprecated Buffer constructor usage #7

wants to merge 1 commit into from

Conversation

oliversalzburg
Copy link

@promatik
Copy link

promatik commented Jul 1, 2020

new Buffer() is being deprecated on Chromium 83, which is used by Electron 9.
This solves that problem, just tested.

@oliversalzburg
Copy link
Author

We abandoned this module just like the maintainer abandoned it. Happy to not have this in our tree anymore

@oliversalzburg oliversalzburg deleted the fix/deprecated-buffer branch July 2, 2020 08:22
@mattdesl
Copy link
Collaborator

mattdesl commented Jul 2, 2020

Fixed in 1.4.1.

We abandoned this module just like the maintainer abandoned it. Happy to not have this in our tree anymore

🤷

@promatik
Copy link

promatik commented Jul 2, 2020

Just updated, works great 👍
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is Buffer used in the browser code?
3 participants