Skip to content

Commit

Permalink
Remove lowercase workaround from signing
Browse files Browse the repository at this point in the history
  • Loading branch information
EyeCantCU committed Dec 18, 2023
1 parent a3b2ad1 commit 9bbbe91
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ jobs:
- name: Sign image
uses: ./sign
with:
container: ghcr.io/${{ github.repository_owner }}/${{ matrix.image_name }}
container: ${{ steps.registry_case.outputs.lowercase }}/${{ matrix.image_name }}
registry: ghcr.io
registry-token: ${{ secrets.GITHUB_TOKEN }}
signing-secret: ${{ secrets.SIGNING_SECRET }}
Expand All @@ -129,7 +129,7 @@ jobs:
- name: Verify image
uses: ./verify
with:
container: ghcr.io/${{ github.repository_owner }}/${{ matrix.image_name }}
container: ${{ steps.registry_case.outputs.lowercase }}/${{ matrix.image_name }}
pubkey: ./cosign.pub

- name: Echo outputs
Expand Down
8 changes: 0 additions & 8 deletions sign/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,6 @@ runs:
username: ${{ github.actor }}
password: ${{ inputs.registry-token }}

# Workaround bug where capital letters in your GitHub username make it impossible to push to GHCR.
# https://github.com/macbre/push-to-ghcr/issues/12
- name: Lowercase Registry
id: registry_case
uses: ASzc/change-string-case-action@v6
with:
string: ${{ inputs.container }}

- name: Install cosign
uses: sigstore/cosign-installer@v3.3.0

Expand Down

0 comments on commit 9bbbe91

Please sign in to comment.