Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds nexus version file #214

Merged
merged 12 commits into from
Jan 22, 2024
Merged

Adds nexus version file #214

merged 12 commits into from
Jan 22, 2024

Conversation

domna
Copy link
Collaborator

@domna domna commented Jan 22, 2024 •
edited
Loading

This is a hotfix and should eventually be fixed in https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/merge_requests/1629

Also we lost version tags, see FAIRmat-NFDI/nexus_definitions#149

@coveralls
Copy link

coveralls commented Jan 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7614230867

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 5 files lost coverage.
  • Overall coverage remained the same at 44.584%
Files with Coverage Reduction New Missed Lines %
tests/dataconverter/test_writer.py 1 96.77%
pynxtools/dataconverter/convert.py 2 76.15%
pynxtools/dataconverter/readers/em_spctrscpy/utils/hspy/em_hspy_adf.py 2 11.38%
pynxtools/dataconverter/readers/em_spctrscpy/utils/hspy/em_hspy_eels.py 3 9.38%
pynxtools/dataconverter/readers/em_spctrscpy/utils/hspy/em_hspy_xray.py 4 8.59%
Totals Coverage Status
Change from base Build 7614206302: 0.0%
Covered Lines: 4906
Relevant Lines: 11004
💛 - Coveralls

@domna domna merged commit 1d8e625 into master Jan 22, 2024
6 checks passed
@domna domna deleted the add-nexus-version-file branch January 22, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherjeelshabih sherjeelshabih sherjeelshabih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domna @coveralls @sherjeelshabih