Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes for XPS reader #220

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Hotfixes for XPS reader #220

merged 5 commits into from
Feb 19, 2024

Conversation

lukaspie
Copy link
Collaborator

@coveralls
Copy link

coveralls commented Jan 23, 2024

Pull Request Test Coverage Report for Build 7633239648

  • 12 of 15 (80.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 44.579%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pynxtools/dataconverter/readers/xps/reader.py 12 13 92.31%
pynxtools/dataconverter/readers/xps/sle/sle_specs.py 0 1 0.0%
pynxtools/dataconverter/readers/xps/txt/txt_scienta.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pynxtools/nexus/nxdl_utils.py 2 74.95%
Totals Coverage Status
Change from base Build 7632295519: -0.005%
Covered Lines: 4905
Relevant Lines: 11003

💛 - Coveralls

@lukaspie
Copy link
Collaborator Author

Hey @domna, can we merge these changes? They are needed for the north example to work.

Copy link
Collaborator

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry, I did not review because this was still set as a draft.

@lukaspie
Copy link
Collaborator Author

Right, my bad. Thanks for the review.

@lukaspie lukaspie marked this pull request as ready for review February 19, 2024 14:58
@lukaspie lukaspie merged commit db40a6a into master Feb 19, 2024
6 checks passed
@lukaspie lukaspie deleted the xps-fixes branch February 19, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants