Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update requirements test with nomad. #430

Merged
merged 8 commits into from
Sep 13, 2024
Merged

update requirements test with nomad. #430

merged 8 commits into from
Sep 13, 2024

Conversation

RubelMozumder
Copy link
Collaborator

No description provided.

@sanbrock
Copy link
Collaborator

LGTM

@RubelMozumder RubelMozumder marked this pull request as ready for review September 13, 2024 10:14
mkuehbach
mkuehbach approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@mkuehbach mkuehbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukaspie
Copy link
Collaborator

Line 34: replace by sed -i 's|pynxtools\[convert\]==[0-9]\+\(\.[0-9]\+\)\{0,2\}|pynxtools\[convert\]@git+https://github.com/FAIRmat-NFDI/pynxtools.git@${{github.head_ref || github.ref_name }}|' default_plugins.txt

@RubelMozumder RubelMozumder merged commit 30919d9 into master Sep 13, 2024
13 checks passed
@lukaspie lukaspie deleted the Fix_nomad_dependency branch September 13, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuehbach mkuehbach mkuehbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RubelMozumder @sanbrock @lukaspie @mkuehbach