Allow UFL element to be created from UFL cell #649
Conversation
| @@ -1229,6 +1230,8 @@ def create_element(family: _typing.Union[_basix.ElementFamily, str], cell: _typi | |||
| gdim: The geometric dimension of the cell. | |||
|
|
|||
| """ | |||
| if isinstance(cell, _ufl.cell.Cell): | |||
There was a problem hiding this comment.
Could try/except be used here? Nice to avoid C++ style type checks if we can.
There was a problem hiding this comment.
I can't see a way to do it that isn't a complete mess.
There was a problem hiding this comment.
The "complete mess" that would make it work:
try:
cell = cell.cellname()
except:
pass
try:
cell = _basix.cell.string_to_type(cell)
except:
passThere was a problem hiding this comment.
What if we only accept a basix.CellType? A lot of merit to there being only one way to do something.
There was a problem hiding this comment.
create_element is a convenience function in the UFL wrapper to make it more user friendly to create elements. I've aimed to make the interface of this function as similar to the current UFL FiniteElement constructor as possible and it saves most users from having to write garbage like:
element = basix.ufl_wrapper.BasixElement(basix.create_element(basix.ElementFamily.P, basix.CellType.triangle, 2, basix.LagrangeVariant.equispaced))There was a problem hiding this comment.
But potentially accepting strings is enough and we don't need this additional option for input
|
Closing this as FEniCS/dolfinx#2604 is a better solution to this |
Fixes #648