Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not store .doctrees binary files on website #751

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Do not store .doctrees binary files on website #751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pythonapp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ jobs:
doxygen
cd ../python
python -m sphinx -W -b html source build/html
rm -rf build/html/.doctrees
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the files that get actually uploaded are those generated with doc/web/make_html.py, right? If so, the addition of this line is probably unnecessary, the addition that matters is the one in doc/web/make_html.py.

- name: Upload C++ documentation artifact
uses: actions/upload-artifact@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion doc/web/make_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,5 +267,5 @@ def system(command):
f.write(" demo/index")

# Make python docs
system(f"cd {path('python')} && python3 -m sphinx -W -b html source/ build/html")
system(f"cd {path('python')} && python3 -m sphinx -W -b html source/ build/html && rm -rf build/html/.doctrees")
system(f"cp -r {path('python/build/html')} {path('html/python')}")
Loading