Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrete interpolation wrong for non-affine elements (using Jacobians in transformations) #2275

Closed
jorgensd opened this issue Jul 20, 2022 · 1 comment · Fixed by #2281
Closed

Discrete interpolation wrong for non-affine elements (using Jacobians in transformations) #2275

jorgensd opened this issue Jul 20, 2022 · 1 comment · Fixed by #2281
Assignees
@jorgensd
Labels
bug Something isn't working high-priority
Milestone
v0.5.0

Comments

@jorgensd
Copy link
Sponsor Member

Inside the discrete interpolation operator, the derivatives (of cmap basis) at the first quadrature points is used to compute jacobians https://github.com/FEniCS/dolfinx/blob/main/cpp/dolfinx/fem/discreteoperators.h#L200-L203

This should be changed in:
https://github.com/FEniCS/dolfinx/blob/main/cpp/dolfinx/fem/discreteoperators.h#L274
to use the q-th entry of https://github.com/FEniCS/dolfinx/blob/main/cpp/dolfinx/fem/discreteoperators.h#L200-L201
@jorgensd jorgensd added the bug Something isn't working label Jul 20, 2022
@garth-wells garth-wells mentioned this issue Jul 21, 2022
Merged
@jorgensd
Copy link
Sponsor Member Author

jorgensd commented Jul 21, 2022 •
edited
Loading

Also affects non-matching map interpolation

@garth-wells garth-wells added this to the v0.5.0 milestone Jul 22, 2022
jorgensd added a commit that referenced this issue Jul 22, 2022
@jorgensd
Fixes Discrete interpolation wrong for non-affine elements (using Jac…
f4dc966 
…obians in transformations) #2275
@jorgensd jorgensd mentioned this issue Jul 22, 2022
Merged
jorgensd added a commit that referenced this issue Jul 22, 2022
@jorgensd @garth-wells
Fix interpolation for non-affine geometries for discrete operator (in…
d584d3a 
…terpolation_matrix) and non-matching maps in function.interpolate (#2281)

* Fixes Discrete interpolation wrong for non-affine elements (using Jacobians in transformations) #2275

Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgensd jorgensd

Labels
bug Something isn't working high-priority
Projects
None yet
Milestone
v0.5.0
2 participants
@garth-wells @jorgensd