Add missing attribute to Fides files #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
@massimiliano-leoni could you add a reference to: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/9201
and which merge request for Paraview that is relevant in the Pull Request description?
|
@jorgensd I added the relevant VTK commit. There isn't a corresponding merge request in Paraview because the change upstream is enough and VTK is handled as a submodule. Anything else that I can add? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion at https://gitlab.kitware.com/paraview/paraview/-/issues/21369 , Fides files need an attribute
Fides_Time_Variablethat tells what variable specifies the time step values. This pull request adds this missing attribute.See also:
Relevant VTK commit: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/9201
Corresponding Paraview revision:
50128b6cc7c5a31334021689766b92988f1a651f