-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let integration entities be specified manually #2269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garth-wells
reviewed
Mar 7, 2023
garth-wells
requested changes
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last task is to replace some std::vector<std::int32_t>
with py::array_t
.
Might need to do some copies, but maybe some std::vector
can be changed to std::span
in C++ layer. Depends on how clever casting is.
…CS/dolfinx into jpdean/manual_integration_domains_2
garth-wells
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Form
computes which entities to integrate over from aMeshTags
object. This is fine for many common use cases, but in more specialised applications, it is useful to be able to specify the entities to assemble over manually. For instance, the user may want to perform a "one sided" facet integral on some interior facets of the mesh, which is not currently possible.This PR refactors
Form
so that the entities to integrate over can be specified manually. A free function has been added to compute integration entities from meshtags, rather than this being computed in the formForm
class.There are still a few issues to fix:
ufl_id
, it causes this check to fail. However, the check may not be necessary. If it is,id
could be called on the data instead.