Add ipygany and pythreejs to dolfinx/lab. #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker layer is less than 26 MB Add clearing of pip cache to further reduce image size.
|
It's OK for me, but wait until the other Dockerfile changes have gone through before merging. |
garth-wells
requested changes
Jul 26, 2022
Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk>
garth-wells
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages used for plotting in notebooks.
They are preferable as they do note require frame-buffers, see: https://docs.pyvista.org/user-guide/jupyter/index.html#state-of-3d-interactive-jupyterlab-plotting
The additional packages adds less than 26 MB to the Docker container
Added clearing of pip cache to further reduce image size.