Cmake-format support #2431
Merged
Cmake-format support #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Note that the demo cmake files are generated by https://github.com/FEniCS/dolfinx/blob/main/cpp/cmake/scripts/generate-cmakefiles.py |
|
I quite like it. Would also be good to have this added as a non-blocking step in the CI. |
garth-wells
previously requested changes
Nov 7, 2022
|
Can you make sure that cmakelang gets put into the Dockerfile so it can be subsequently tidied up in the GitHub action after the merge (one day!). |
jhale
approved these changes
Nov 8, 2022
jhale
dismissed
garth-wells’s stale review
I believe the issue with the demo cmake files was addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.