Mixed topology #2597
Merged
Mixed topology #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/dolfinx into mixed-topology-hackathon-23
…nx into mixed-topology-hackathon-23
…nx into mixed-topology-hackathon-23
…nx into mixed-topology-hackathon-23
…nx into mixed-topology-hackathon-23
|
I've pushed this branch up as a PR because there are a lot of changes, and I don't want to lose them. Mostly, the changes are just related to changing "unique" to "list" for mesh properties (celltype, elementdoflayout etc.) |
garth-wells
requested changes
Mar 28, 2023
garth-wells
approved these changes
Mar 31, 2023
jorgensd
reviewed
Mar 31, 2023
| auto cell_types = mesh->topology().cell_types(); | ||
| if (cell_types.size() > 1) | ||
| { | ||
| throw std::runtime_error("MUltiple cell types in the assembler"); |
There was a problem hiding this comment.
Suggested change
| throw std::runtime_error("MUltiple cell types in the assembler"); | |
| throw std::runtime_error("Multiple cell types in the assembler"); |
This was referenced Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some rudimentary support for mixed topology/geometry.
At present, much of the functionality is at the 'stub' level, i.e. replacing:
CellType,ElementDofLayoutandCoordinateElementwith lists instead of a single value for aMesh.The main new feature is the
entity_group_offsetswhich defines the blocks of entities (i.e. cells or facets) which exist.Cells are kept in blocks in the topology, e.g. triangles, then quads, followed by ghost triangles and ghost quads. The offsets point to the start/end point of each block.