Export CMAKE_PREFIX_PATH in helper installation scripts
#2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhale
approved these changes
Nov 14, 2023
|
It isn't strictly necessary to be up to date with main to merge. The merge queue will handle merging main into your branch and running the test suite. |
|
I'll wait to see if @garth-wells has any comment, and after that I'll merge to main. |
garth-wells
requested changes
Nov 15, 2023
garth-wells
approved these changes
Nov 15, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mimicks the already existing export of
PKG_CONFIG_PATHand helps downstream development in the nightly docker image.This change is not required when building the docker nightly image itself, but I honestly do not understand why:
CMAKE_PREFIX_PATHorDOLFINX_DIR, yet (as manually verified with a few runs) the complex installation gets correctly detected./usr/local/dolfinx-real/lib/dolfinx/dolfinx.conf, yet the real installation gets correctly found, even if it is in a non standard path.I also have verified that without
CMAKE_PREFIX_PATH(and withoutDOLFINX_DIR) one could have had mixed configurations when using the nightly image, in which after sourcing/usr/local/dolfinx-complex/lib/dolfinx/dolfinx.confthe python part is imported from/usr/local/dolfinx-complex, while the C++ one from/usr/local/dolfinx-real.