-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct CMAKE_BUILD_TYPE in end user Docker images #2894
Conversation
I would propose we remove Perhaps we should go for Edit: I'm thinking the tagged versions e.g. |
We can discuss the nanobind performance issues separately. |
Agreed, this is a separate issue. It is mostly important to get some better performance on the nightly images. |
Remove CMAKE_CXX_FLAGS, it does not work anyway because |
Once we are done with the change proposed by @michalhabera , can @jorgensd manually trigger https://github.com/FEniCS/dolfinx/actions/workflows/docker-end-user.yml ? |
I can also trigger my own pipelines, as I've got several tests timing out because of this |
@jorgensd Can you also remove |
Let's improve issue and PR names. This is a Docker-only change but the title is very broad. |
The issue is still a regression issue due to transfering to nanobind. Happy to rename this PR though. |
Can #2895 be merged before this, and then merge the updated |
Related to the nightly timings #2891.
We still have a regression with the introduction of nanobind, but now we are down to a halving in performance.