Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading commit message when updating documentation repository #2914

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

francesco-ballarin
Copy link
Member

Noticed this while I was investigating whether to prepare an equivalent of FEniCS/basix#751 for dolfinx. At first glance I couldn't understand why there wasn't a push of the python part of the documentation: there was, but it was stored alongside the cpp in a commit message starting with C++.

@francesco-ballarin
Copy link
Member Author

For reference, the reason why this doesn't need a change similar to the one in FEniCS/basix#751 is because of/thanks to the use of * in

      - name: Copy documentation into repository
        ...
        run: |
          ...
          cp -r ../python/doc/build/html/* dolfinx/${{ env.VERSION_NAME }}/python

@francesco-ballarin francesco-ballarin added documentation Documentation improvements or fixes ci Continuous Integration labels Nov 29, 2023
@jhale jhale enabled auto-merge November 29, 2023 19:38
@jhale jhale added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 8eefd77 Nov 29, 2023
20 checks passed
@jhale jhale deleted the francesco/docs-commit-msg branch November 29, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration documentation Documentation improvements or fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants