Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GMSH quadrilateral recombination options to force pure quadrilateral meshes #2940

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

jorgensd
Copy link
Sponsor Member

@jorgensd jorgensd commented Dec 23, 2023

Resolves #2938.
Follows guidance from: https://gmsh.info/doc/texinfo/gmsh.html

// The default recombination algorithm might leave some triangles in the mesh,
// if recombining all the triangles leads to badly shaped quads. In such cases,
// to generate full-quad meshes, you can either subdivide the resulting hybrid
// mesh (with Mesh.SubdivisionAlgorithm = 1), or use the full-quad recombination
// algorithm, which will automatically perform a coarser mesh followed by
// recombination, smoothing and subdivision. Uncomment the following line to try
// the full-quad algorithm:

Tested locally with: ghcr.io/fenics/dolfinx/dolfinx:v0.7.2-r1@sha256:29c96c06ceda98a234de0d5f1a2c94e839fe0335a065d62c2ed1f56b9df76b22

@jorgensd jorgensd added bug Something isn't working backport? Suggest PR for backporting labels Dec 23, 2023
@garth-wells garth-wells added the demo New demo or demo enhancements/improvements label Dec 23, 2023
@garth-wells garth-wells added this pull request to the merge queue Dec 23, 2023
Merged via the queue into main with commit 488136b Dec 23, 2023
19 checks passed
@garth-wells garth-wells deleted the dokken/gmsh-quads branch December 23, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport? Suggest PR for backporting bug Something isn't working demo New demo or demo enhancements/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: :v0.7.x ARM images all fail python/unit/test/mesh/test_higher_order_mesh.py
2 participants