-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify mesh creation interface and algorithms #2954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrichardson
approved these changes
Jan 5, 2024
…inx into garth/mesh-simplifications-4
jorgensd
added a commit
to jorgensd/dolfinx_mpc
that referenced
this pull request
Jan 8, 2024
jorgensd
added a commit
to jorgensd/adios4dolfinx
that referenced
this pull request
Jan 8, 2024
jorgensd
added a commit
to jorgensd/dolfinx_mpc
that referenced
this pull request
Jan 8, 2024
* Fixes related to FEniCS/dolfinx#2890 Currently need to rewrite distribute_ghost_data, as it needs all blocks to create the compressed map. Plan is to add it as extra input * Resolve issues with global_to_local. See: FEniCS/dolfinx#2963 * Fix option name * Revert branches * API changes from: FEniCS/dolfinx#2954
jorgensd
added a commit
to jorgensd/adios4dolfinx
that referenced
this pull request
Jan 8, 2024
* API changes: FEniCS/dolfinx#2954 * Add dev0 to dep bound * Add dtype to basix.ufl elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the interfaces for mesh creation from topology and geometry data, and simplifies many of the associated algorithms. It fixes #2949.
Background
The mesh interface has been complicated by using an adjacency list for cells when we only support one cell type in a mesh, and by having vectors of cell type and element coordinate maps in topology and geometry, and an obscure 'cell offset' array. The current discussion on how to support mixed topology meshes is pointing away from an adjacency list being the appropriate data structure for cells of mesh. The direction of travel is to store different cell types separately. This will make many algorithms much simpler, and it preserves the
IndexMap
abstraction (which was broken when mixing different cell types in a single data structures.Next steps
When adding mixed topology support, we should start from the bottom up. The eventual design will inform the appropriate interfaces.
If we need functions like:
we should do
to avoid (i) introducing pollution throughout the code and (ii) to give much more robust error handling as we transition to supporting mixed topology.