Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom C/C++ kernel demo #2983
Custom C/C++ kernel demo #2983
Changes from 7 commits
05f964f
55cf9db
320f26e
f67ce51
1e5c375
d7a10cf
d51bf7e
22f0bcd
7b83f85
73a14d7
1f5b1b8
9b8348a
1061437
41375a4
0ece7ef
01f26c8
4eab682
0db48b2
82b3999
7b3e588
0a52367
dede3d3
6901321
aea1e36
c024486
b1f1c9a
44ea39c
19c0841
9af8b84
09c449d
9c81aec
dda707f
a66f011
c65ddb6
2babb9f
530ea0d
a13b8f6
0a8e98f
a550fac
1c79fc6
bae9bcd
f981578
16dc137
5634d63
be82c95
232b019
bff5b44
3eebd0d
73710d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe Basix should use an enum for the last arg - booleans are hard to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not clear what
false
is - should we make it an enum?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mscroggs What do you think?