-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop cffi_utils failing on KeyError #2993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are CI tests managing to pass without this change?
the images on CI have types that are in |
I can’t see what other NumPy types petsc4py supports. Can you check what the petsc4py integer and scalar types are in your image? |
IntType is |
Maybe just add |
Done, but I think it's worth merging the rest of this in too so that if someone at any point uses petsc with a type we're yet to include, they only get errors when using |
If PETSc's int or scalar type is not in
_CTYPES
, dolfinx currently throws aKeyError
on import. This will prevent that, and errors will only occur ifcffi_utils
is used.