Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make isort check blocking #3002

Closed
wants to merge 2 commits into from
Closed

Make isort check blocking #3002

wants to merge 2 commits into from

Conversation

garth-wells
Copy link
Member

Now that we set isort configuration options in pyproject.toml I think we can be stricter on import sorting.

@garth-wells garth-wells added the ci Continuous Integration label Jan 20, 2024
@francesco-ballarin
Copy link
Member

I think @jhale is already planning to make it blocking in #2998. If we plan to merge #2998 somewhat soon, maybe this change could be deferred there, to avoid having to sort through merge conflicts between the two PRs.

@francesco-ballarin
Copy link
Member

#2998 has been added to the merge queue, and will also make isort blocking. Closing.

@garth-wells garth-wells deleted the garth/isort-block branch March 29, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhale jhale Awaiting requested review from jhale

Assignees
No one assigned
Labels
ci Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garth-wells @francesco-ballarin