Fix interior facet permutations #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 22, 2024 13:20
…zil/dolfinx into anzil/fix-interior-facet-permutations
|
Thanks for finding and fixing this subtle bug! There is a patch coming in with the aim of removing PETSc solvers from the tests; can you wait for that to come in and then update? |
jhale
previously requested changes
Jan 23, 2024
jhale
dismissed
their stale review
This is related to PETSc's block assembler, so this test needs to be made optional based on PETSc's availability when we get there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is joint work with @michalhabera and supersedes #3000.
Non-symmetric assembled operators were observed for bilinear forms that combine e.g. Nedelec and Regge elements when interior facet integrals were present in the form.
This PR fixes post dof transformation during sub-block matrix/vector assembly for interior facet integrals.