Ruff format mk2 #3044
Merged
Ruff format mk2 #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jhale
commented
Feb 7, 2024
jhale
commented
- Format, still some line too long errors?
- Modify CI.
- Remove flake8 and isort from image.
- Format C++ part.
- Fix remaining check issues.
Removed periodic bc test file, no longer needed.
| module_name = f"_petsc_cffi_{worker}" | ||
| if MPI.COMM_WORLD.Get_rank() == 0: | ||
| ffibuilder = cffi.FFI() | ||
| ffibuilder.cdef("""typedef int... PetscInt; | ||
| ffibuilder.cdef( |
There was a problem hiding this comment.
Am I reading this right: ruff also formatted the C code in the string, not only the python code around it?
That is not an issue here, but we may want to be aware of this when applying ruff format e.g. to ffcx, which I guess has more parts like this one.
There was a problem hiding this comment.
In general though, I think it is bad that ruff edits the contents of triple quotes.
|
Not really happy about the multi-line imports, formatting around the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.