Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple dofmaps and elements to Geometry #3071

Merged
merged 124 commits into from
Mar 3, 2024

Conversation

chrisrichardson
Copy link
Contributor

Updates dofmapbuilder to build multiple dofmaps (on the same range) using multiple element dof layouts, when there is a mixed topology.

@garth-wells garth-wells added the enhancement New feature or request label Feb 27, 2024
cpp/dolfinx/fem/utils.cpp Outdated Show resolved Hide resolved
cpp/dolfinx/fem/utils.cpp Outdated Show resolved Hide resolved
cpp/dolfinx/fem/utils.cpp Show resolved Hide resolved
cpp/dolfinx/fem/utils.h Outdated Show resolved Hide resolved
cpp/dolfinx/fem/utils.h Outdated Show resolved Hide resolved
python/dolfinx/wrappers/mesh.cpp Outdated Show resolved Hide resolved
python/test/unit/fem/test_mixed_mesh_dofmap.py Outdated Show resolved Hide resolved
python/test/unit/fem/test_mixed_mesh_dofmap.py Outdated Show resolved Hide resolved
python/test/unit/fem/test_mixed_mesh_dofmap.py Outdated Show resolved Hide resolved
python/test/unit/mesh/test_mixed_topology.py Outdated Show resolved Hide resolved
@chrisrichardson chrisrichardson marked this pull request as ready for review February 27, 2024 17:11
Copy link
Member

@garth-wells garth-wells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part way through . . .

cpp/dolfinx/fem/dofmapbuilder.cpp Show resolved Hide resolved
cpp/dolfinx/fem/dofmapbuilder.cpp Outdated Show resolved Hide resolved
cpp/dolfinx/fem/dofmapbuilder.cpp Show resolved Hide resolved
cpp/dolfinx/fem/dofmapbuilder.cpp Outdated Show resolved Hide resolved
cpp/dolfinx/fem/dofmapbuilder.cpp Outdated Show resolved Hide resolved
cpp/dolfinx/fem/dofmapbuilder.cpp Outdated Show resolved Hide resolved
cpp/dolfinx/fem/dofmapbuilder.cpp Outdated Show resolved Hide resolved
cpp/dolfinx/fem/dofmapbuilder.cpp Outdated Show resolved Hide resolved
cpp/dolfinx/fem/dofmapbuilder.cpp Outdated Show resolved Hide resolved
cpp/dolfinx/fem/dofmapbuilder.cpp Outdated Show resolved Hide resolved
Copy link
Member

@garth-wells garth-wells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some tiny comments.

cpp/dolfinx/fem/dofmapbuilder.cpp Outdated Show resolved Hide resolved
cpp/dolfinx/fem/dofmapbuilder.cpp Show resolved Hide resolved
cpp/dolfinx/fem/dofmapbuilder.cpp Show resolved Hide resolved
@chrisrichardson chrisrichardson added this pull request to the merge queue Mar 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2024
@chrisrichardson chrisrichardson added this pull request to the merge queue Mar 3, 2024
Merged via the queue into main with commit 0f85bab Mar 3, 2024
19 checks passed
@chrisrichardson chrisrichardson deleted the chris/geometry-mix-more branch March 3, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants