Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more explicit that this site does not have feature parity with RITlug's #87

Closed
ct-martin opened this issue Feb 16, 2020 · 1 comment · Fixed by #92
Closed

Be more explicit that this site does not have feature parity with RITlug's #87

ct-martin opened this issue Feb 16, 2020 · 1 comment · Fixed by #92
Assignees
@jwflory
Labels
documentation Improvements or additions to documentation improvement Improves on something that already exists

Comments

@ct-martin
Copy link
Member

From comment in FOSSRIT/runbook#30

As I'm reading this I'm also realizing the code functionality is no longer the same as the RITlug site from combination of things that weren't merged to the FOSS site after being added to the RITlug site as well as changes for FOSS-specific things that didn't go upstream to the RITlug site. It would be worth explicitly mentioning that somewhere to prevent confusion.

Some specific examples for reference:

  • RITlug has a post-event layout that uses extra metadata for a nicer displaying of events
    • There are some accompanying template changes for this too (beyond the layout)
  • FOSSRIT removed the talk layout & tweaked other templates as a result
  • RITlug has a calendar page (PR Add Calendar page #85 for merging here)
  • RITlug uses metadata more heavily as a result
    • This matters for docs

To be clear, I'm not looking to completely dissociate the sites. This isn't too big of an issue, but as the sites are heavily related in code, it would be helpful to have noted in CONTRIBUTING.md for anyone who is contributing to both sites (particularly since the README.md notes this site is based on the RITlug site).
@ct-martin
Copy link
Member Author

(Also, if you have a better title for the issue, please feel free to change)

@jwflory jwflory added needs triage Metadata needs to be triaged and updated documentation Improvements or additions to documentation improvement Improves on something that already exists and removed needs triage Metadata needs to be triaged and updated labels Feb 20, 2020
@jwflory jwflory self-assigned this Feb 20, 2020
jwflory added a commit that referenced this issue Feb 26, 2020
@jwflory
🔍 Note lack of feature parity with RITlug site (closes #87)
2646ba3 
This commit adds a note to the README that this website does not have
full feature parity with the RITlug site, and links to issue #87 where
there is more specific details on the differences.

Closes #87.

Signed-off-by: Justin W. Flory <git@jwf.io>
@jwflory jwflory mentioned this issue Feb 26, 2020
Merged
jwflory added a commit that referenced this issue Feb 26, 2020
@jwflory
🔍 Note lack of feature parity with RITlug site (closes #87)
d87fd2a 
This commit adds a note to the README that this website does not have
full feature parity with the RITlug site, and links to issue #87 where
there is more specific details on the differences.

Closes #87.

Signed-off-by: Justin W. Flory <git@jwf.io>
jwflory added a commit that referenced this issue Feb 26, 2020
@jwflory
🔍 Note lack of feature parity with RITlug site (closes #87) (#92)
0b5f538 
This commit adds a note to the README that this website does not have
full feature parity with the RITlug site, and links to issue #87 where
there is more specific details on the differences.

Closes #87.

Signed-off-by: Justin W. Flory <git@jwf.io>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwflory jwflory

Labels
documentation Improvements or additions to documentation improvement Improves on something that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Note lack of feature parity with RITlug site (closes #87) FOSSRIT/fossrit.github.io
2 participants
@jwflory @ct-martin