fix parsing trailing message content from CMGR command #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I have here something for issue #180 that doesn't fell like a huge hack.
Still probably a hack but a hope a small one.
It misuses
fields
attribute fromdeserialize_struct()
, saves it count in the Deserializer.Then SeqAccess does count how many fields it already parsed, if it hits the branch that no
,
are present anymore and the count of parsed fields is exactly one less then the expected count of fields to parse it sets a flag in the Deserializeris_trailing_parsing
to indicate thatparse_str
orparse_bytes
should now just take everything left and try to parse it.This does seam to work fine for my use case, but I bet it still has some edge cases where it might not work.
Doesn't seam to break any other tests and I add a test for my use case.