Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unecesarry final in BeanDeserializerBase causing production problems for custom deserializers #420

Closed
Ghoughpteighbteau opened this issue Mar 4, 2014 · 5 comments

Comments

@Ghoughpteighbteau
Copy link

public final Object deserializeWithType(JsonParser jp, DeserializationContext ctxt,
            TypeDeserializer typeDeserializer)

is the only entry point for when jackson mapper is deserializing a collection of objects with polymorphic types.

I have a custom version of the beanDeserializer that does partial updates, it also pulls references from our database when we use syntax that indicates a reference.

However because this field is marked as final, I can't change the deserialization behaviour for references inside collection if the types are polymorphic.

I have being trying to work around this problem for a month. a literal month.

please remove this keyword!

@cowtowncoder
Copy link
Member

Which version is this?

@Ghoughpteighbteau
Copy link
Author

well. I'm using version 2.2.0

but it's in this version as well. Here:

cowtowncoder added a commit that referenced this issue Mar 5, 2014
@cowtowncoder
Copy link
Member

Fix for 2.3 branch (for 2.3.3 if and when it is released), master (for 2.4.0).

Earlier branches are not maintained so new version of 2.1 or 2.2 will be released.

@Ghoughpteighbteau
Copy link
Author

That's more than enough! Thanks Tatu! I'll just jump to 2.3 with the fix.

I should of asked for that sooner rather than try and hack around it. I am perhaps too cynical 😊

@cowtowncoder
Copy link
Member

:)

No problem. I wish I had gotten this in 2.3.2, but better late than never.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants