Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NamedType iteration predictable by using LinkedHashSet instead of HashSet in StdSubtypeResolver.collectAndResolveSubtypesByTypeId() #4086

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Make NamedType iteration predictable by using LinkedHashSet instead of HashSet in StdSubtypeResolver.collectAndResolveSubtypesByTypeId() #4086

merged 1 commit into from
Aug 20, 2023

Conversation

JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Aug 19, 2023 •
edited
Loading

(blocks #4065)

Motivation

Since HashSet does not guarantee any particular order, StdSubtypeResolver.collectAndResolveSubtypesByTypeId() can be flakey, resulting in test failures such as 🔗this github action.

Modification

  • Use LinkedHashSet to allow predictable iteration order

@JooHyukKim JooHyukKim mentioned this pull request Aug 19, 2023
Merged
cowtowncoder
cowtowncoder approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, LGTM.

@cowtowncoder cowtowncoder merged commit c6522de into FasterXML:2.16 Aug 20, 2023
3 checks passed
@cowtowncoder cowtowncoder added this to the 2.16.0 milestone Aug 20, 2023
@JooHyukKim JooHyukKim deleted the 4061-use-LinkedHashSet-in-StdTypeResolver branch August 20, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JooHyukKim @cowtowncoder