Skip to content
This repository has been archived by the owner on Jan 22, 2019. It is now read-only.
This repository has been archived by the owner on Jan 22, 2019. It is now read-only.

Polymorphic deserialization involving Guava Optional<T> is broken #42

Closed
bbeck opened this issue May 2, 2014 · 6 comments
Closed

Polymorphic deserialization involving Guava Optional<T> is broken #42

bbeck opened this issue May 2, 2014 · 6 comments
Milestone

Comments

@bbeck
Copy link

bbeck commented May 2, 2014

Between 2.2.3 and 2.3.2 the technique of deserializing an optional polymorphic type using @JsonTypeInfo and @JsonSubTypes no longer seems to work. Without the Guava Optional<T> everything works fine.

Self-contained example demonstrating the problem can be found here: https://gist.github.com/bbeck/934d787cc36c61c3e8a0

@cowtowncoder
Copy link
Member

Thank you, I will try to reproduce, figure out what is going on.

@cowtowncoder
Copy link
Member

Looking at change notes, #37 would seem related, but it was in 2.3.3.

@bbeck
Copy link
Author

bbeck commented May 5, 2014

I just tested with 2.3.3 as well and my example still breaks. 😦

@cowtowncoder
Copy link
Member

Sure, I was more trying to understand what caused breakage, not that it would yet be fixed.
Although of course would have been nice if it had been fixed, but... :)

cowtowncoder added a commit that referenced this issue May 5, 2014
@cowtowncoder cowtowncoder added this to the 2.3.4 milestone May 5, 2014
@cowtowncoder
Copy link
Member

Ok, although fixing was rather more involved than I expected, this is now fixed both for master (2.4) and 2.3 branch (for eventual 2.3.4).

@bbeck
Copy link
Author

bbeck commented May 5, 2014

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants